From patchwork Sun Jun 28 15:13:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Babic X-Patchwork-Id: 1318601 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::437; helo=mail-wr1-x437.google.com; envelope-from=swupdate+bncbcxploxj6ikrbkhh4l3qkgqetzo5yni@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=Az4c+HUp; dkim-atps=neutral Received: from mail-wr1-x437.google.com (mail-wr1-x437.google.com [IPv6:2a00:1450:4864:20::437]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49vvK758d3z9sDX for ; Mon, 29 Jun 2020 01:13:47 +1000 (AEST) Received: by mail-wr1-x437.google.com with SMTP id z3sf15396916wrr.7 for ; Sun, 28 Jun 2020 08:13:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1593357224; cv=pass; d=google.com; s=arc-20160816; b=Q5c5/nEBNC4k97wPSXD54kmoypjFCESrszTw3FwxQNwQ9osJNytF5pFS7diRS5uLPc 5e30yBgyW0NWI775HXYgs+R5NZp9vqd1DHZEj/FO/lGqb4o0lw57QwIJx4jsTnhVGanw +NcyQMga/fPtSHIeq73jYzyy4SJkv3SwArMwyYw4KUD9BRIDJ8IuRAeAqN70YAw97tEe pSUMGfeqO7BLZgC4lxwIuPoPQ1Eq8h+OC2jY+QHetbDMHTGppGF1ZLg7AylmzPEp+HYH pvC+jD0dh59/S+ZCGdm0eD/guaohxwr6XD+PozN18cHq1cDXBFkw9qxX5i1acUrxzLIf NG/Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=/415bd5el+f4X4UY9tOQaZYXUsBj8HUoW5zl8tYM7sY=; b=q9J1OS1nT8ssizEFtT9SIEoPSw9IC6+2zMb/mORrpOW1u+Gw1xhKN7bnPUr3GPPEp0 K4lPujXyYRtQXN+E+8nj77vGGEFZsJHohFBDxLQF8Z3J6qrwJIRLDS6WjyN4Wrwtw4eD 2M3g6kZoV9d5NaFzDZ28vTKeshMnpnamlI6vC5TRcf4geBVjXzc7blIV9IwiXn460yeb LdxMkfLn7165RAMC5Sw7r7mnVXOoG32SMegMUArozVfzaA7wxmVPtXHrDaJ0DXtZoQTK q6yi/0sstpFzV8tds300nUotW9jxi04fj/XGAYY0K8bWahEAu/8SLbYRqG1aWLrTeKPq JCsw== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=/415bd5el+f4X4UY9tOQaZYXUsBj8HUoW5zl8tYM7sY=; b=Az4c+HUp2LovFKUmel66e4YIvEKaLtdt8sP9jtBUBWW+nbWUd7erP+ACEssLt8uVaz N80XU+FUZEE77cjeHuE+cKYVIBIlq8/UeKhFmDKxerVU6ad3nQW0k8J6970xqPUNmD1a CEAjk4+J27MkWz2KDTajNFm3dn35ZCVahgykiIV3eJ4Gx2qlri/Q2SJRiN9B0ZdVTwmS hQBhxMTZgO1G4L1au4EoSF89XA0O+74N306pXYqxbItiKJ9bmnHirvjpjtVfsXv2Qre8 C6EMzN7JCaVKrAxAcmQlvibrnhWoGayWwA/RXNS8KIihU4BYRNHGjfs7FiyE0PqUxLrz HavA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=/415bd5el+f4X4UY9tOQaZYXUsBj8HUoW5zl8tYM7sY=; b=sDZw7HrizctFzSMg1oG46oBeAhsH/B/frLMy7RzZHdueQkOIZKGwZqzxkOpzFj+uwe P6eI2WJnZz754ev3Erru1DqX7au3B5LoqlX5bDN03MqB9jCP3MjjqydI6AUalNrs6GMJ 2XzSy34+fAoQWe/9Cnm2ddv8flpICfEXlk8Fi3WvMu+t1Ue/hyk8qIOnUsu8p1XFOE2P gLghm9chHVwSicKp+VVRSQRE3M5HLJLKolwFWBj18pRaG2iUOmnQKNud0OAr4gmug0B8 JNRd+Jq/j3uDFjTXMqBv0lYdjJhfpuapIW1OrpJl4042ZLOdXWrPs57KNWVseg8HCcWp BeyQ== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM532PSJepg+0upoITtwvUg+TiU4LIOF9jRXAfx/OMiXhqcErpbjT/ Ys+vDeQVAsFZue2/XHJg1S4= X-Google-Smtp-Source: ABdhPJyiOKI+lVh2ydlbwhTUwT1fwP5BQ1QsRqcjJA27zflPUmy5AmE+o+ir1qgt/BWc2uQg0wXGJA== X-Received: by 2002:adf:e6c8:: with SMTP id y8mr14012040wrm.40.1593357224764; Sun, 28 Jun 2020 08:13:44 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:adf:82ca:: with SMTP id 68ls4336557wrc.2.gmail; Sun, 28 Jun 2020 08:13:44 -0700 (PDT) X-Received: by 2002:adf:a507:: with SMTP id i7mr14327314wrb.0.1593357224190; Sun, 28 Jun 2020 08:13:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593357224; cv=none; d=google.com; s=arc-20160816; b=srMJwBYmBZG1WiOIF0iMyZJi4COD3MnunM2b3UxarzTYRPY99Lk79dfdkLQEJrr1kF uTB3aNrHRdndaCGLKS98HYKY5iReaQ8bCOB3S6shBh541DYTc9H8h/Nx/mDKjv4bO2Uv SYjVgMHxzqsNa51JY2X9DSotQDBklQLniDh9kiUNFsSSpAIxBZ1FfYrSglwL7HSKkDOl AL5AyNKwS+a7cDxeEuf2Ncp3odmVmrHs6tb5q+3Bd8QKqw7ER2xO+KGMliQ2YFL53BoZ OHR362p+2CTbOI54tNRS3lSF3d5GtKT+jKmH85JrekmFqaJc4z3QxDG0x+MAp4fiWlJN Z8Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=sCdJCxA1jBH6fV52P2hPNparjc1iCaFDJICnnPBlX6A=; b=qsaHoauEZFrpXlb3bCkg4J3bAO3ZW9NdSzYcS2HY3AK70HN2Hf4xIrRG3dJFkJX3G7 NIC8DB2MUCgxQW3b1FZjwIWi44zQU91wvddaxFa3VRqa8Qqn1d2MRByTF31lFhdKtWuo szuBnAVuVRGbK7hPQZxXNtcgKJehPolDTaQdNwtb8bV+9xwW/Oc1VlMg8x+6hIbSqOoT eKTVbJPv8DCaQsVBUIpimVvjNRLu8Dr8JKl/PIxYmDdUdZ3giLn7I0Pbc2AXsR7i2QRw ElXV+uihESudbuQ7HJtbkwL4f+mSLvyN4JWq2UlyJJFttx0IP5doPnBfzIs103YaMBJu b8bw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Received: from mail-out.m-online.net (mail-out.m-online.net. [2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id 14si997392wmk.1.2020.06.28.08.13.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Jun 2020 08:13:44 -0700 (PDT) Received-SPF: neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 49vvK36Vyqz1rsNT; Sun, 28 Jun 2020 17:13:43 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 49vvK369mlz1qw6c; Sun, 28 Jun 2020 17:13:43 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id K-kzg1Pou2_L; Sun, 28 Jun 2020 17:13:43 +0200 (CEST) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Sun, 28 Jun 2020 17:13:43 +0200 (CEST) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id D0FC44540511; Sun, 28 Jun 2020 17:13:42 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([IPv6:::1]) by localhost (mail.babic.homelinux.org [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id rjHuxL8ruVk7; Sun, 28 Jun 2020 17:13:40 +0200 (CEST) Received: from paperino.fritz.box (paperino.fritz.box [192.168.178.64]) by babic.homelinux.org (Postfix) with ESMTP id 319E34540645; Sun, 28 Jun 2020 17:13:38 +0200 (CEST) From: Stefano Babic To: swupdate@googlegroups.com Cc: Stefano Babic Subject: [swupdate] [libubootenv 3/6] Fix coverity #293495 and #293497 Date: Sun, 28 Jun 2020 17:13:33 +0200 Message-Id: <20200628151336.952051-3-sbabic@denx.de> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200628151336.952051-1-sbabic@denx.de> References: <20200628151336.952051-1-sbabic@denx.de> MIME-Version: 1.0 X-Original-Sender: sbabic@denx.de X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Buffer not null terminated in strncpy(), initializes to 0. Signed-off-by: Stefano Babic --- src/uboot_env.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/uboot_env.c b/src/uboot_env.c index f92977b..8086463 100644 --- a/src/uboot_env.c +++ b/src/uboot_env.c @@ -1147,7 +1147,8 @@ int libuboot_read_config(struct uboot_ctx *ctx, const char *config) ctx->size = dev->envsize; if (tmp) { - strncpy(dev->devname, tmp, sizeof(dev->devname)); + memset(dev->devname, 0, sizeof(dev->devname)); + strncpy(dev->devname, tmp, sizeof(dev->devname) - 1); free(tmp); } @@ -1323,7 +1324,8 @@ int libuboot_configure(struct uboot_ctx *ctx, for (i = 0; i < 2; i++, envdevs++, dev++) { if (!envdevs) break; - strncpy(dev->devname, envdevs->devname, sizeof(dev->devname)); + memset(dev->devname, 0, sizeof(dev->devname)); + strncpy(dev->devname, envdevs->devname, sizeof(dev->devname) - 1); dev->envsize = envdevs->envsize; dev->sectorsize = envdevs->sectorsize; dev->envsectors = envdevs->envsectors;