diff mbox series

remote_handler: Fix coverity #292143

Message ID 20200416191401.10717-3-sbabic@denx.de
State Accepted
Headers show
Series ucfw_handler: Fix coverity #292172 | expand

Commit Message

Stefano Babic April 16, 2020, 7:14 p.m. UTC 
Signed-off-by: Stefano Babic <sbabic@denx.de>
---
 handlers/remote_handler.c | 5 +++++
 1 file changed, 5 insertions(+)
diff mbox series

Patch

diff --git a/handlers/remote_handler.c b/handlers/remote_handler.c
index 6747996..275859f 100644
--- a/handlers/remote_handler.c
+++ b/handlers/remote_handler.c
@@ -94,6 +94,8 @@  static int RHmsg_get_ack(struct RHmsg *self, void *request)
 
 	size = zmq_msg_size(&self->frame[0]);
 	string = malloc (size + 1);
+	if (!string)
+		return -ENOMEM;
 	memcpy (string, zmq_msg_data (&self->frame[0]), size);
 	string[size] = '\0';
 	zmq_msg_close(&self->frame[0]);
@@ -107,6 +109,7 @@  static int RHmsg_get_ack(struct RHmsg *self, void *request)
 		len = (strchr(string, ':') - string - 1);
 	if (strncmp(string, "ACK", len) != 0) {
 		ERROR("Remote Handler returns error, exiting");
+		free(string);
 		return -EFAULT;
 	}
 
@@ -121,6 +124,8 @@  static int RHmsg_get_ack(struct RHmsg *self, void *request)
 			timeout = newtimeout;
 	}
 
+	free(string);
+
 	return 0;
 }