diff mbox

ucfw_handler: Fix coverity #292172

Message ID 20200416191401.10717-1-sbabic@denx.de
State Accepted
Headers show

Commit Message

Stefano Babic April 16, 2020, 7:13 p.m. UTC 
Signed-off-by: Stefano Babic <sbabic@denx.de>
---
 handlers/ucfw_handler.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox

Patch

diff --git a/handlers/ucfw_handler.c b/handlers/ucfw_handler.c
index cf6de74..19a778e 100644
--- a/handlers/ucfw_handler.c
+++ b/handlers/ucfw_handler.c
@@ -473,7 +473,8 @@  static int get_gpio_from_property(struct dict_list *prop, struct mode_setup *gpi
 	memset(gpio, 0, sizeof(*gpio));
 
 	LIST_FOREACH(entry, prop, next) {
-		char *s = strdup(entry->value);
+		char *sstore = strdup(entry->value);
+		char *s = sstore;
 		for (i = 0; i < 3; i++) {
 			char *t = strchr(s, ':');
 
@@ -498,6 +499,7 @@  static int get_gpio_from_property(struct dict_list *prop, struct mode_setup *gpi
 				break;
 			s = ++t;
 		}
+		free(sstore);
 	}
 
 	return 0;