From patchwork Sat Apr 11 14:34:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Babic X-Patchwork-Id: 1269345 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::139; helo=mail-lf1-x139.google.com; envelope-from=swupdate+bncbcxploxj6ikrbbfly72akgqexpqd2xy@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=XXWKuBAM; dkim-atps=neutral Received: from mail-lf1-x139.google.com (mail-lf1-x139.google.com [IPv6:2a00:1450:4864:20::139]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48zy8B0y72z9sSj for ; Sun, 12 Apr 2020 00:34:48 +1000 (AEST) Received: by mail-lf1-x139.google.com with SMTP id t194sf1735604lff.20 for ; Sat, 11 Apr 2020 07:34:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1586615684; cv=pass; d=google.com; s=arc-20160816; b=jcHCfoMh8vyi/YGWApST4GGLzkqVVqwtN1JCgzySGDvAfQhG1uqmT0rEXJSyAbKJ2j paDOfTVZAFvRpe4g2SnAxo5vCQQQhlOBkQ6P7tpcg3IJpsb5H7QMaM2bVyGDIOvmiwJ6 cFicGfhunBxzbZAJB1Fm8xZzom2gy1DKFdQvXtkl7rNjxrE5UrZx64PsaEn+tOVnhuv2 V1+y4e7sjq2cBsKEf6GfC+4D2W1PcPA0PGNdDph8gJ30tceiLH1KVt6Epc7ErPMlxYtL PFWvQYpY+edQu7iZZ6SOZpGV+EA6kGIWrLdfquP3d93kLlkvVoMZJPFIw+PAWZLgkkaS dbgg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=p8Og3YjfWnfRlIdrpBfrh9pRmFi5r1vHOMJlJ/rC3aM=; b=p8wEjdDo7KLM2r/4J+2sRckZj37jNFFrFmvqetENl7R6T8aBVSwozWZfiR/8VOVk1k P4TA/LP1tSbqQmDJosPfAUHqwei8SQoNlmzCN8PNQs5CmnVk7uWHcrKaExKbMN5T6WQi zfjXOuOC+Q2o3Fbb0K3f5oB7v8XlGJnhjsDr9PuTxsMTRU/zdgFzDxpyJcJZtRtJzwEY eOFKtKHTqm8YF6NC/SByQsIhbmlXxPhGnaXETa8XGcL7Nj0iNDZMPzV6b5e3kkSoxZnH y5cWYcB9p6qrejvwT+tfTvHUbAHZNEdfSKarTsjUGanNoYfgTmtD87jcp3bnAswrud9r lNww== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=p8Og3YjfWnfRlIdrpBfrh9pRmFi5r1vHOMJlJ/rC3aM=; b=XXWKuBAMp5o1VJRmmbHJzsKB30PJLvydIVBZ2ff+JyBM+W6fkw1PfZVjnhbeMRv/Y/ 6ijampd7xBQA6sfZ34yTBAtykdsNR9F/kRwMoTmLToBHcqPNJo2kDQgSrV4yMGpU/z2Q 2moJc3uMx1cCL4FmSTRutXBBHC7hn2N43/N1sgRjpKdOZp5Dm+VOEfVSgO57rN8LWtxF s6P2kpksguQg+o19FptTfCSufS03GeYF6PZ52DJJzo0h8PTNR3B0cFQdQBCGh8gDaKZB NCwk6iY+q5FMWEAERrUufSzrkunlsG1Lt80OHMI0SzpQIJex+PcA0HfjK7QmRUTxrBQe /Mtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=p8Og3YjfWnfRlIdrpBfrh9pRmFi5r1vHOMJlJ/rC3aM=; b=l8DSZXNUHpptYirDwSoNVp/5N+qtQxUVnHjb3K0K1kZxZIzBZ+jOvxqWO3tVcLpGvk cRPWGyrI7r2WDIvHWhoyxHQ4l8/UC8/MSvzn6/G8m62Hu/u36Msaa2ZDOZk8WGojRWrQ LlQPrw5/IjMYtPXUSOV5E1zAfbZA0dTnvny2Gx57d/4AFlk6VQS9UfAGVtTV3SiV6K/J IojyFkJSosvA9A5WVi7lqaOanCtpgh6ukzwlpOT5/ysRSvoT4KGk9k7Pbjc96UACnTIx /AYNLhv0aOcrneHn0AEcjXqlrk2bRW15InA5py4HCHGk+n8HNfbTfMoJKrQICEze8J+G 1UsQ== Sender: swupdate@googlegroups.com X-Gm-Message-State: AGi0PuZFK5nZ/Y7BgQ4JwDR3ANg6/uWE/yA0eIn4MGZOMcFhRxd+DTSy AgL8/gADZVVs7+VCxEYbsC8= X-Google-Smtp-Source: APiQypICzTTMuEqIeKr/1h/iYB2IyfIxytjcJsdrg9B+8tm+JVMAWvQ5Qm08ovXhuy1sz8ZNLJZV7A== X-Received: by 2002:a19:550a:: with SMTP id n10mr5465127lfe.143.1586615684852; Sat, 11 Apr 2020 07:34:44 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a2e:b4c6:: with SMTP id r6ls2505844ljm.0.gmail; Sat, 11 Apr 2020 07:34:44 -0700 (PDT) X-Received: by 2002:a2e:3c08:: with SMTP id j8mr6077411lja.243.1586615684105; Sat, 11 Apr 2020 07:34:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586615684; cv=none; d=google.com; s=arc-20160816; b=x7nZr60xK2Mju7LBdGcWiXytYDY5HPeQZ32o/ctwOebiqH1KjEZ+IqpNLQ62GBYzRg +iPR5xOBSU0Qv43Mka1D7lK8Er56Lzk1qz+xw2/Q59K4zsCX4uEVj0VuYqV61aVOSVuK VkbWKAS60/o3MXX27+3YkB1nCXlO1l+D8NJiWMt/1gh1uP2+lFOXCcjVt35njSGkA8c/ ztisYv7jWuIe/rw/HJsB4Asphom1plXourKL64xSBDegFnTeV4BkoGQyBBtN7b2Eq6Al u/28LjofDfk7P3mtm4gReK0wOTsnZiO3kJTVWKUacMrspizowba6CNpaMCHTWpEMQ1p3 ndyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=O7XT5s09OfN+2wsUOCeCmgoPlsx3MsGovKyV/MCkkUQ=; b=lXs5Qv6fXL3I8vMIMzeyGhrHdGJqix3GhV41AvPOjuoegZxX4Oe14ZdupMN0I4fflU vlfALWsy8CplGfOm9W1pXxDfrfH7OGqg4oFPzkMJfrwmMrKrv5BF3rm+H315d7zU1AYg Ag18U9J606EyK0fTp9oo2kKdQYo/21ZrmqBgYkUHjjQvYkdkVUSVYTfa5HhYWGGtB7sZ XvL8cXwJQYTqeV1g3hMMnLupv0aiynWI/rtUBG4ryKzr9Eelz1WdjvHWsNyONVf78d6M C2xlxm+BQKEGayHbrBCZIm9WzBxdRjy0oCSnyMT05XVSexdzprBtgacCsrquryrnXLFT 6KIw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id f25si248031lfc.3.2020.04.11.07.34.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Apr 2020 07:34:44 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) client-ip=212.18.0.9; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 48zy834NrNz1qrgD; Sat, 11 Apr 2020 16:34:43 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 48zy834FY8z1r0c1; Sat, 11 Apr 2020 16:34:43 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id LQjkzLrMAYxw; Sat, 11 Apr 2020 16:34:43 +0200 (CEST) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Sat, 11 Apr 2020 16:34:42 +0200 (CEST) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id ABE3045405F7; Sat, 11 Apr 2020 16:34:42 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([IPv6:::1]) by localhost (mail.babic.homelinux.org [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 9YlYGDYYGR0g; Sat, 11 Apr 2020 16:34:40 +0200 (CEST) Received: from paperino.fritz.box (paperino.fritz.box [192.168.178.38]) by babic.homelinux.org (Postfix) with ESMTP id 579F445406B6; Sat, 11 Apr 2020 16:34:40 +0200 (CEST) From: Stefano Babic To: swupdate@googlegroups.com Cc: Stefano Babic Subject: [swupdate] [PATCH] Fix coverity #292124 Date: Sat, 11 Apr 2020 16:34:30 +0200 Message-Id: <20200411143430.24525-3-sbabic@denx.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200411143430.24525-1-sbabic@denx.de> References: <20200411143430.24525-1-sbabic@denx.de> MIME-Version: 1.0 X-Original-Sender: sbabic@denx.de X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Signed-off-by: Stefano Babic --- core/artifacts_versions.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/core/artifacts_versions.c b/core/artifacts_versions.c index 85faaf4..6fe5d60 100644 --- a/core/artifacts_versions.c +++ b/core/artifacts_versions.c @@ -59,6 +59,9 @@ static int read_sw_version_file(struct swupdate_cfg *sw) swcomp = (struct sw_version *)calloc(1, sizeof(struct sw_version)); if (!swcomp) { ERROR("Allocation error"); + fclose(fp); + free(name); + free(version); return -ENOMEM; } strlcpy(swcomp->name, name, sizeof(swcomp->name));