Message ID | 20200320123803.17474-1-sbabic@denx.de |
---|---|
State | Accepted |
Headers | show
Return-Path: <swupdate+bncBCXPLOXJ6IKRBMPS2LZQKGQENOGU4VA@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::537; helo=mail-ed1-x537.google.com; envelope-from=swupdate+bncbcxploxj6ikrbmps2lzqkgqenogu4va@googlegroups.com; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=c8k1ThVV; dkim-atps=neutral Received: from mail-ed1-x537.google.com (mail-ed1-x537.google.com [IPv6:2a00:1450:4864:20::537]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48kNbt2ySFz9sSR for <incoming@patchwork.ozlabs.org>; Fri, 20 Mar 2020 23:38:16 +1100 (AEDT) Received: by mail-ed1-x537.google.com with SMTP id i10sf4928161edk.13 for <incoming@patchwork.ozlabs.org>; Fri, 20 Mar 2020 05:38:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1584707890; cv=pass; d=google.com; s=arc-20160816; b=QAStO/AmFeuX8ArNpfGVupAL3B/GkNwS8tAvGXNKr7x/R2F8gSWcRjQMeG+VLRmkZW hhOnMZHDHwQDGOq0zMwGJT0/84UgEgpXbqZgTZumVXkby6lgQmgpe3xLZcS/Tl5OdDB1 HFgfsGhHeLTqWQX5dSZ+9KId+LAwHSavdVt0Tc0w1OgyvA7b3CYMDMlPTB/2JFznkUXp byhUOMUWGkw7hSg1kg41kbDkpYTgu+lATZNI+J1lCOCBhVRnyXnKg+467FqTklOwhD6t jvmNXZAHQUqwExIVCfmuvMCO3Pt5PM1MKy0HK44kYoP7uwfkQXiR//w673m/Lh2hSNHH 5SGw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=0xUkaYQd8baJn7rbIOxlPMhPWK3qJwURVcQx3v3Ko6s=; b=vW6n0nj7NLHGhYIULetcM5LxfCojE12rllmnEJ4w4i6iajuYctTjda4aTL+VfrpU81 ednM5gwJIPr15S4HGZ1TP5iyYuxGCiZ8nBrItj2vh4kt3cWPpIk9ODSPSFDeXHZh1I3j gQiGLV6af4LFi52yVXgSxdLFMjy5eRQ8XlMjijJbkSsXxNhnbQqFCPRKqxjTtbUQquRa LiRrbvYmHY4QCkBel6NlrMYI2MCtnBZ8bE6wFtH4Rqe2WbvfUEQSi5rM+Y2e5JHrJmZE SUKbQHomd1IMiezLs75Guz9+z8mTipR+ymiVbPJcXBQ85w8AGz/9S4C6p7XEj8nFx4h8 LVWA== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=0xUkaYQd8baJn7rbIOxlPMhPWK3qJwURVcQx3v3Ko6s=; b=c8k1ThVVaTY5ggTv/mmonMoMnuNGLjGOzgAuS71Ukv0sGpV6Own+ASuFbkF13Jd6Q2 eM/7yg9QTVLZwB78XdXkDH5eRi1ZmhXaUxnsArU4mjRqlfWAyYNb6woPOFbVUS5PVjCi s46ASrMcqczlTPC30EUbvvArglo+GyL8X4mWWJQnUmExF8HrTxuAO1B0XTwZNPX0yjGj TlkB2IQMnzlUBmTZqlmBbIXCi9lGBHUNKQI6hMdVHMhInCguvDlh3UTM2tfpZZ3SIyhU 27aLhgQLDta7BZXYhNs9WEel0gMJE7Qs/wSM/JKXleMz5qQigk3jdKxbPWlWE6lx7wWc vuog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=0xUkaYQd8baJn7rbIOxlPMhPWK3qJwURVcQx3v3Ko6s=; b=gEnfMa9IRr5e+rCedw/QFSGgpMRB2cJDG3Al7KNkZafbOs8u2qpi7/tUKGk98plRzM lld8OIyrAP5OHz3QilAzPSdOkTNvE+gRVpIkUeV4ePtKrWNchW03lyl93wtRiiEMxPmn xjCpnTvoWQApWKGMLB+xbEGEvisGDJe7DOne3Z64liuf3W6489M34sWBuOF4NwdmHB0t nm8pC+udzuWgvVpoCz29qWsg6D20Xj6fE0EU/8I/C/F9AjyXURLGT6xlcv1FVgSlqnOe MjB66Z3Q4QbVqUm7HAc+ao++iCzYEr7Y24SzGTCmC7u7HxChDLqGPxkfiDxu7KNAsLkx POjw== Sender: swupdate@googlegroups.com X-Gm-Message-State: ANhLgQ16pu554/cO4iiqqa3a2J5gVXBfxW4SfUtEqfhToQrOSpCEyW87 mBoCYGbp7oWXjkKx9pi+fMc= X-Google-Smtp-Source: ADFU+vtlfyWZZ3RswqgxYAWtyHx0b+IBCO8Khqb2+fdJf3+tLeZncI6rVON5n1yng/lmU5/g3WAtDg== X-Received: by 2002:a50:d987:: with SMTP id w7mr7454695edj.276.1584707889999; Fri, 20 Mar 2020 05:38:09 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a17:906:344d:: with SMTP id d13ls2967424ejb.8.gmail; Fri, 20 Mar 2020 05:38:09 -0700 (PDT) X-Received: by 2002:a17:906:2acb:: with SMTP id m11mr8138269eje.180.1584707889322; Fri, 20 Mar 2020 05:38:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584707889; cv=none; d=google.com; s=arc-20160816; b=MEnOp93e76rHZ5Fc3BTJNOicdz0cHLT556j37UAfxKmBwfWmGqfoi8RkMJSc8edA/H DicVDPd8Zndv9j9eMJNR7vYaPBn06ZCEfXfkcUwNjtLCdlOLNaZmnsIVz5B4Z2l889+o wRNtANIdu2naM7MNTc1ZVxtqIzZnZEAwf/4dFhRIaQz/QQnqIBsZMfccmZVOZrlyLQU4 scpmG6KGZGjgSK/pOwoDMLbvEr+JRANpTBjDyOYmn+4h9kqLR8ygy2TOqA+tl0VkEl5g p02mwiJDx/7wB6Y9CS6cubJhojMYVu07m7l7y3/dicxhpBlwNFNBAXBPbJcmZa9gdw78 v+iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=Fa+L3E5yzo2VWaQL72E3k0lpHC1+NOkEd0nS4kanUvo=; b=DtdfUdmyoQTMUDqWZggBrJOttYiYGAnkdpu55SINl9ramRHRAp5dm1UcC5gV3s818O IH3MrfEbu2uPXJWFKFnyPRY9EBhANKs9d9E4/YsUjioVSkKgEzIdYjt3BKsORre1iRf9 zxlixI6uGNbdqXQnurRKAA5omQ/8unvMkzzZsyt0oYGO8PfLLKsk+9yvKkMkO05VeGit Owz45gT5NhPByzlhLZIxdkNG1wDrbeOOu376H2baJKG9wHSnvgHDLByYHXucG3D4M6A5 bN2RMf7729U4aTm3h6cYLg5TZrWHIaBOJLMa4o7CRAdnzf7JBfbuM/5jC82lnVG3gEci zrlg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Received: from mail-out.m-online.net (mail-out.m-online.net. [2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id e19si292385edr.3.2020.03.20.05.38.09 for <swupdate@googlegroups.com> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Mar 2020 05:38:09 -0700 (PDT) Received-SPF: neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 48kNbj0JbQz1tBx8; Fri, 20 Mar 2020 13:38:09 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 48kNbj046xz1qrbr; Fri, 20 Mar 2020 13:38:09 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 5V-vDX7_2qqj; Fri, 20 Mar 2020 13:38:08 +0100 (CET) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Fri, 20 Mar 2020 13:38:08 +0100 (CET) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id BBC764540514; Fri, 20 Mar 2020 13:38:08 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([127.0.0.1]) by localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w9s6-jZuDFjA; Fri, 20 Mar 2020 13:38:06 +0100 (CET) Received: from paperino.fritz.box (paperino.fritz.box [IPv6:fd00::3c8a:dc96:b15:e92e]) by babic.homelinux.org (Postfix) with ESMTP id 2E4BC4540297; Fri, 20 Mar 2020 13:38:06 +0100 (CET) From: Stefano Babic <sbabic@denx.de> To: swupdate@googlegroups.com Cc: Stefano Babic <sbabic@denx.de> Subject: [swupdate] [PATCH] BUG: all images runs in streaming mode Date: Fri, 20 Mar 2020 13:38:03 +0100 Message-Id: <20200320123803.17474-1-sbabic@denx.de> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Original-Sender: sbabic@denx.de X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: <swupdate.googlegroups.com> X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: <https://groups.google.com/group/swupdate/post>, <mailto:swupdate@googlegroups.com> List-Help: <https://groups.google.com/support/>, <mailto:swupdate+help@googlegroups.com> List-Archive: <https://groups.google.com/group/swupdate List-Subscribe: <https://groups.google.com/group/swupdate/subscribe>, <mailto:swupdate+subscribe@googlegroups.com> List-Unsubscribe: <mailto:googlegroups-manage+605343134186+unsubscribe@googlegroups.com>, <https://groups.google.com/group/swupdate/subscribe> |
Series |
BUG: all images runs in streaming mode
|
expand
|
diff --git a/core/stream_interface.c b/core/stream_interface.c index 46a0dc0..163c253 100644 --- a/core/stream_interface.c +++ b/core/stream_interface.c @@ -256,7 +256,7 @@ static int extract_files(int fd, struct swupdate_cfg *software) * sure that the UBI partitions are adjusted beforehand */ LIST_FOREACH(part, &software->images, next) { - if (!part->install_directly) { + if (!part->install_directly && part->is_partitioner) { TRACE("Need to adjust partition %s before streaming %s", part->volname, img->fname); if (install_single_image(part, software->globals.dry_run)) {
Commit 16f44d8b4 is supposed to run all partioners before installing the first image in streaming mode. The loop is intended to run for all partitioners mode, but without checking the type, it runs for all images, independently if it is supposed to change a partition. This results in an update failure if the image must be treated by a handler that does not support streaming mode. Signed-off-by: Stefano Babic <sbabic@denx.de> --- core/stream_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)