| Message ID | 20191008174705.29735-2-adrian.freihofer@siemens.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [[libubootenv] 2/3] add missing includes | expand |
Hi Adrian, On 08/10/19 19:47, Adrian Freihofer wrote: > Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com> > --- > src/uboot_private.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/uboot_private.h b/src/uboot_private.h > index e332283..4b7a9f9 100644 > --- a/src/uboot_private.h > +++ b/src/uboot_private.h > @@ -8,7 +8,9 @@ > #pragma once > > #include <stdbool.h> > +#include <stdint.h> > #include <sys/queue.h> > +#include <mtd/mtd-user.h> > #include "libuboot.h" But these are already included by uboot_env.c, and uboot_private.h is not exported. I have seen neither errors nor warnings up now. Which is the use case causing build error ? Best regards, Stefano Babic
Hi Stefano, The error occurs when including uboot_private.h in my new c file which does not add the required headers. With V2 of my patches this will no longer be the case. Should I remove the patch from V2 or would you like to get this minor issue fixed? Regards, Adrian Am Dienstag, 8. Oktober 2019 23:14:17 UTC+2 schrieb Stefano Babic: > > Hi Adrian, > > On 08/10/19 19:47, Adrian Freihofer wrote: > > Signed-off-by: Adrian Freihofer <adrian....@siemens.com <javascript:>> > > --- > > src/uboot_private.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/src/uboot_private.h b/src/uboot_private.h > > index e332283..4b7a9f9 100644 > > --- a/src/uboot_private.h > > +++ b/src/uboot_private.h > > @@ -8,7 +8,9 @@ > > #pragma once > > > > #include <stdbool.h> > > +#include <stdint.h> > > #include <sys/queue.h> > > +#include <mtd/mtd-user.h> > > #include "libuboot.h" > > > But these are already included by uboot_env.c, and uboot_private.h is > not exported. I have seen neither errors nor warnings up now. Which is > the use case causing build error ? > > Best regards, > Stefano Babic > > -- > ===================================================================== > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de > <javascript:> > ===================================================================== >
diff --git a/src/uboot_private.h b/src/uboot_private.h index e332283..4b7a9f9 100644 --- a/src/uboot_private.h +++ b/src/uboot_private.h @@ -8,7 +8,9 @@ #pragma once #include <stdbool.h> +#include <stdint.h> #include <sys/queue.h> +#include <mtd/mtd-user.h> #include "libuboot.h" typedef enum {
Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com> --- src/uboot_private.h | 2 ++ 1 file changed, 2 insertions(+)