From patchwork Wed Apr 17 08:39:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Storm, Christian" X-Patchwork-Id: 1086852 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::440; helo=mail-wr1-x440.google.com; envelope-from=swupdate+bncbdd6bwv65qpbbfwm3psqkgqet5scrca@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=siemens.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b="Vko34YmF"; dkim-atps=neutral Received: from mail-wr1-x440.google.com (mail-wr1-x440.google.com [IPv6:2a00:1450:4864:20::440]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44kbHZ65ZQz9s5c for ; Wed, 17 Apr 2019 18:38:49 +1000 (AEST) Received: by mail-wr1-x440.google.com with SMTP id u18sf21672107wrp.19 for ; Wed, 17 Apr 2019 01:38:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1555490326; cv=pass; d=google.com; s=arc-20160816; b=os/m5DdWnuUsDZvULUKy2B+N97t4XETnAl4etcDUQylnZrdcODKrziFloRRA+JDM5F N17Qr3GX9v6y1DbHGGXMj/mFFNnAFnFWj6aAlWn5aD3zalUWnxm6OPVYHfvhoMBqBmEX qQ0oxhh5u69dc74a1XJcnH2G29znNIsedzpi31Qbvz/GfT/P7LSzXNdfs82BCJoAeV0w smQU4S8gr0LzIE6BeVmmEswmqjxdsCT2K8gkHUTvQ0BKNtSpkQaMNmgIAsLrY/IhJM+M crxIp2BIzKnbthfntUMhJUxwjy+uTVsJaLch440g6GKTil9eITJfdA4SbbxwxaIJ/YbJ y69A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=vF3jlzOj+XSPRMBptuSTNIASKH4caDMSCS5jdbTUn0w=; b=DTPWqDusX0xr/hVVRjc/Paz2GU6NmdYIzkVCPgjEOUn5D4ah9YeE4MO+nDSTigWmUK zUGZeCWG5zWQIlOPW1Xn1eSoI33bTGtvtAm0R1QxAZXZa9nUql10CIHKBNQq1RS7pAnm aMmOSUZLOvxkugr9PqCqN0dm/KYTk5P6Z7e1op+eotcvDFVkhJCP42DnOLnH+c0+dsV8 71jq9LnCkh3lTc9qWygUIw1zO/Tjn/ZfJ05voSt0vFE6SiTUaouwuIcNLBhwR+U95+9i lzd7XUqkjavkia/O1SLCdhX0i6pGdT6gkNlt8qUvhdYbUSg4wRV0dyUssoxLVVCde0he KhVA== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of christian.storm@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=christian.storm@siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=vF3jlzOj+XSPRMBptuSTNIASKH4caDMSCS5jdbTUn0w=; b=Vko34YmFEXpZtC8K+pOlXkZP85QCQjrWPnhmrn8CGixbaK252HRtzqkwsxTZflwoZv rfBW5vJrNH63uZagqNCUfEm+SVjAZveYSe8VQb7gT/f3pmNykINf2OACkbirdjUqgBZr r8gpUy2+rx590utcHwHR3YGf+u8GNrDu9DwL16VV1FG1E5jQ4s2WirTabS0eCtex1gE1 T2/rougr0yq28xC8yto1C/BUHEnPx9uqMnbjHnjLiicBBWrj69NAOPYJR4Y+gVle66aJ c+L8WWkxtEN62txdf90Ef63EqtmbU7MTeoBDkPWwtNI0u+AW317tMrgshbj9A9r/IS/0 i4uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=vF3jlzOj+XSPRMBptuSTNIASKH4caDMSCS5jdbTUn0w=; b=XZ3Kx7PTpziXF3e5Ok+Eoj5MDmzSeIFrDKrFwdCrOXdNANootsfVdSDRsMJmu2YG1o A/VNZlMWBK61kjHcokLeqSfHqgO5porKiJsw6stFfiCKnZyH00E3E8K4vn8xmQRCAvjn x1T3X7Jch13wQiE+t+6Km4ve7nbAB8IWmLgVW3BQslSr9eZo3QSbEJ3RP4Mxph7Li/PS 4WpW/vG6OlYUZHFXCs83ijqBg1RY6axc2RZlCaLVsjOmZemctulKvIRHVJD4ufh3Rp7D I/1awdBf0Tm14yJjOhox1BZ1vKg29ayiX9Sd2EY9m1ZJwIipFHBlBKcFE0fmc3SzaMl6 gZCQ== Sender: swupdate@googlegroups.com X-Gm-Message-State: APjAAAVr3R0La9BA8EJTBAN5BuoghxsjFR+cnRza95jo/mRBj1COLxSX nH6FwWshF3EmxUvF+gUU48g= X-Google-Smtp-Source: APXvYqznFYTjf1KRCspqGaiNv1EqFTUBgqmgKldrXHBoLEHh5FGY4fydL460v60+ET5Y3baaWkRnlw== X-Received: by 2002:a1c:4d02:: with SMTP id o2mr29929611wmh.134.1555490326328; Wed, 17 Apr 2019 01:38:46 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a1c:dc43:: with SMTP id t64ls667745wmg.5.gmail; Wed, 17 Apr 2019 01:38:45 -0700 (PDT) X-Received: by 2002:a1c:2355:: with SMTP id j82mr3622378wmj.7.1555490325810; Wed, 17 Apr 2019 01:38:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555490325; cv=none; d=google.com; s=arc-20160816; b=E4eThK81Qa9owkuV7xzffcMkRgdWoHRnlfFZ4aqd5S/sCaka8Q4HoGy55bzHr/1a+/ nGllpkCZeb556B1C1Nd35VWX39CnlsX6yyoPT9WRaV0zzdELGiO7N5PpOoxfw1ou32vG Ddh3hAQzR9l8WNffrQ+7MpFu1wRt9Kn6dLV0I2grFaSarWhI8Is+Iuwl4X6D2Ixs+Zsg a8AcjDzSaDHdZP8FkNgseKiV7B52QQzHnpXKZ36T5hN5ZL+pgR73v2BSoog37t5hA01V M2Pc35bPGQyQr5csFkIq4ubuAivrIQPpci42FJDHYw3n/1OTNCGAgUWWCkBBr8hYJwtO CHXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=mthqH7M0F+BARYBENSDONxOKPQ45E7Alkz1404U5DoA=; b=nmxmkMAhUHObSgBQA5HX4sKCn2QVaJSQAbpMIKoml1Q2LbzWhNgxH3+JYbWovo/uhh eTR8nhddrflN7F+kdYuBjy0XtACSPfMYNLTYUEJYzJ+ZfCts4awnLepbyebYX68R+JAs 6gPS8HomEVL0dIfETuX+/Plu8NZKBnibBGF2hc8hft4qs4GsJ9Z+e2e//VmVRgJ9Uj36 EUIOHIpEuZFAYZaJjkWpKbYepFEbYurh4M7H0kA7/Ioo69D6kbBiZQN1v4gdL/Gp+1/e nxxMNnkZUV/joNifIUcDuINK6FQBitcC7DL3kDJmsrTTDd8e81DROjQmfh0pLQjUQdhk 8HoQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of christian.storm@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=christian.storm@siemens.com Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id z185si253246wmb.0.2019.04.17.01.38.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Apr 2019 01:38:45 -0700 (PDT) Received-SPF: pass (google.com: domain of christian.storm@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x3H8cjqA024662 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 17 Apr 2019 10:38:45 +0200 Received: from MD1ZFJVC.ad001.siemens.net ([139.25.69.166]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id x3H8cju6000384; Wed, 17 Apr 2019 10:38:45 +0200 From: Christian Storm To: swupdate@googlegroups.com Cc: Christian Storm Subject: [swupdate] [PATCH 1/2] ucfwhandler: Fix sign-compare warnings Date: Wed, 17 Apr 2019 10:39:00 +0200 Message-Id: <20190417083901.16905-1-christian.storm@siemens.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-Original-Sender: christian.storm@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of christian.storm@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=christian.storm@siemens.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Signed-off-by: Christian Storm --- handlers/ucfw_handler.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/handlers/ucfw_handler.c b/handlers/ucfw_handler.c index 1d71b05..a14421f 100644 --- a/handlers/ucfw_handler.c +++ b/handlers/ucfw_handler.c @@ -356,10 +356,10 @@ static int receive_msg(int fd, char *rx, size_t size, static int write_data(int fd, char *buf, size_t size) { - int written; + size_t written; written = write(fd, buf, size); if (written != size) { - ERROR("Error in write %d", written); + ERROR("Error in write %zu", written); return -EFAULT; } @@ -509,7 +509,8 @@ static int install_uc_firmware_image(struct img_type *img, struct handler_priv hnd_data; struct dict_list *properties; struct dict_list_elem *entry; - int cnt, ret = 0; + unsigned int cnt; + int ret = 0; struct mode_setup *gpio; memset(&hnd_data, 0, sizeof(hnd_data));