| Message ID | 20240224140031.9888-1-daniel@braunwarth.dev |
|---|---|
| Headers | show |
| Series | web-app: update web application | expand |
Hi Daniel, On 24.02.24 15:00, Daniel Braunwarth wrote: > This series of patches updates the web application. > > All dependencies are updated to latest versions. > > Additionally some linter issues has been fixed. > > Daniel Braunwarth (5): > web-app: fix linter warning > web-app: update dependencies > web-app: apply "standard" fixes > web-app: update gulp to ES6 > web-app: migrate to bootstrap version 5 > > web-app/css/swupdate.css | 4 +-- > web-app/{gulpfile.js => gulpfile.mjs} | 38 ++++++++++++---------- > web-app/index.html | 44 +++++++++++++------------ > web-app/js/swupdate.js | 47 +++++++++++++++------------ > web-app/package.json | 40 +++++++++++------------ > web-app/scss/bootstrap.scss | 10 ------ > 6 files changed, 92 insertions(+), 91 deletions(-) > rename web-app/{gulpfile.js => gulpfile.mjs} (79%) > Thanks for the series - however, I cannot build the web-app anymore (npm in distro is 8.5.1). > swupdate@0.2.0 build > gulp build SyntaxError: Unexpected token '?' at Loader.moduleStrategy (internal/modules/esm/translators.js:133:18) Can you take a look ? Best regards, Stefano
Hi Stefano Am 29. Februar 2024 um 09:43 schrieb "Stefano Babic" <stefano.babic@swupdate.org>: > Thanks for the series - however, I cannot build the web-app anymore (npm > > in distro is 8.5.1). > > > swupdate@0.2.0 build > > > gulp build > > SyntaxError: Unexpected token '?' > > at Loader.moduleStrategy (internal/modules/esm/translators.js:133:18) > > Can you take a look ? This is caused by an too old version of node. I assume you are running Debian Bullseye which delivers the quite old node version 12. I've tested this with Debian Bookworm and Trixie which both delivers node version 18. Node 18 seems to be a valid choise for me since version 12 is aldready out of maintencance. Best regards Daniel
On 04.03.24 08:37, daniel@braunwarth.dev wrote: > Hi Stefano > > Am 29. Februar 2024 um 09:43 schrieb "Stefano Babic" <stefano.babic@swupdate.org>: > >> Thanks for the series - however, I cannot build the web-app anymore (npm >> >> in distro is 8.5.1). >> >> > swupdate@0.2.0 build >> >> > gulp build >> >> SyntaxError: Unexpected token '?' >> >> at Loader.moduleStrategy (internal/modules/esm/translators.js:133:18) >> >> Can you take a look ? > > This is caused by an too old version of node. Sure. > > I assume you are running Debian Bullseye which delivers the quite old node version 12. > > I've tested this with Debian Bookworm and Trixie which both delivers node version 18. > > Node 18 seems to be a valid choise for me since version 12 is aldready out of maintencance. > Ok - set node 18 as min version for building the app. I have checked in as usual the result of the build under examples. Applied to -master, thanks ! Best regards, Stefano
Hi Daniel, Thank you for updating the web application. I tested the web application and wanted to give feedback. 2 small changes in the user interface caught my attention. [image: swupdate-www-diff.png] -The spinner icon and the location of the icon in the restart modal have changed. - Messages anchor tag does not appear as an anchor now. Does the bootstrap library no longer provides these features in the new version or was it intended to be this way? Thanks in advance for your answer. Best regards, Esad Ergül Stefano Babic schrieb am Montag, 4. März 2024 um 10:32:18 UTC+1: > On 04.03.24 08:37, dan...@braunwarth.dev wrote: > > Hi Stefano > > > > Am 29. Februar 2024 um 09:43 schrieb "Stefano Babic" < > stefan...@swupdate.org>: > > > >> Thanks for the series - however, I cannot build the web-app anymore (npm > >> > >> in distro is 8.5.1). > >> > >> > swup...@0.2.0 build > >> > >> > gulp build > >> > >> SyntaxError: Unexpected token '?' > >> > >> at Loader.moduleStrategy (internal/modules/esm/translators.js:133:18) > >> > >> Can you take a look ? > > > > This is caused by an too old version of node. > > Sure. > > > > > I assume you are running Debian Bullseye which delivers the quite old > node version 12. > > > > I've tested this with Debian Bookworm and Trixie which both delivers > node version 18. > > > > Node 18 seems to be a valid choise for me since version 12 is aldready > out of maintencance. > > > > Ok - set node 18 as min version for building the app. I have checked in > as usual the result of the build under examples. > > Applied to -master, thanks ! > > Best regards, > Stefano > > >
This series of patches updates the web application. All dependencies are updated to latest versions. Additionally some linter issues has been fixed. Daniel Braunwarth (5): web-app: fix linter warning web-app: update dependencies web-app: apply "standard" fixes web-app: update gulp to ES6 web-app: migrate to bootstrap version 5 web-app/css/swupdate.css | 4 +-- web-app/{gulpfile.js => gulpfile.mjs} | 38 ++++++++++++---------- web-app/index.html | 44 +++++++++++++------------ web-app/js/swupdate.js | 47 +++++++++++++++------------ web-app/package.json | 40 +++++++++++------------ web-app/scss/bootstrap.scss | 10 ------ 6 files changed, 92 insertions(+), 91 deletions(-) rename web-app/{gulpfile.js => gulpfile.mjs} (79%) -- 2.43.0