mbox series

[0/6] Add Android support

Message ID 20220306132635.220607-1-gary.bisson@boundarydevices.com
Headers show
Series Add Android support | expand

Message

Gary Bisson March 6, 2022, 1:26 p.m. UTC 
Hi,

This series adds support to build libubootenv library as well
fw_printenv/fw_setenv for Android.

As Android uses the Bionic C library, it doesn't include index/rindex
functions, so those have been changed to strchr/strrchr as recommended
by the man page anyway (see first patch).

As Android uses clang, it showed a few warnings when building, some of
those have been fixed in that series, some of them are discarded in
CFLAGS as explained in the Android.bp addition patch.

The series has been successfully tested on Boundary Devices Nitrogen
platforms with Android 11.

Let me know if you have any questions.

Regards,
Gary

Gary Bisson (6):
  uboot_env: switch to strchr/strrchr
  uboot_env: fix pointer-sign warnings
  uboot_env: remove unused variables
  uboot_env: remove unused parameters
  uboot_env: remove unused function
  Android.bp: initial addition

 Android.bp      | 27 +++++++++++++++++++++++++++
 src/uboot_env.c | 35 ++++++++++++-----------------------
 2 files changed, 39 insertions(+), 23 deletions(-)
 create mode 100644 Android.bp

Comments

Stefano Babic March 8, 2022, 9:22 a.m. UTC | #1 
Hi Gary,

On 08.03.22 09:53, Gary Bisson wrote:
> Hi,
> 
> This series adds support to build libubootenv library as well
> fw_printenv/fw_setenv for Android.
> 
> As Android uses the Bionic C library, it doesn't include index/rindex
> functions, so those have been changed to strchr/strrchr as recommended
> by the man page anyway (see first patch).
> 
> As Android uses clang, it showed a few warnings when building, some of
> those have been fixed in that series, some of them are discarded in
> CFLAGS as explained in the Android.bp addition patch.
> 
> The series has been successfully tested on Boundary Devices Nitrogen
> platforms with Android 11.
> 
> Let me know if you have any questions.
> 
> Changelog v1->v2:
> - Add missing SPDX in Android.bp
> 

Thanks - series is straightforward, thanks for cleanup, applied to -master !

Best regards,
Stefano

> Regards,
> Gary
> 
> Gary Bisson (6):
>    uboot_env: switch to strchr/strrchr
>    uboot_env: fix pointer-sign warnings
>    uboot_env: remove unused variables
>    uboot_env: remove unused parameters
>    uboot_env: remove unused function
>    Android.bp: initial addition
> 
>   Android.bp      | 29 +++++++++++++++++++++++++++++
>   src/uboot_env.c | 35 ++++++++++++-----------------------
>   2 files changed, 41 insertions(+), 23 deletions(-)
>   create mode 100644 Android.bp
>
Gary Bisson March 8, 2022, 9:32 a.m. UTC | #2 
Hi Stefano,

On Tue, Mar 08, 2022 at 10:22:05AM +0100, Stefano Babic wrote:
> Hi Gary,
> 
> On 08.03.22 09:53, Gary Bisson wrote:
> > Hi,
> > 
> > This series adds support to build libubootenv library as well
> > fw_printenv/fw_setenv for Android.
> > 
> > As Android uses the Bionic C library, it doesn't include index/rindex
> > functions, so those have been changed to strchr/strrchr as recommended
> > by the man page anyway (see first patch).
> > 
> > As Android uses clang, it showed a few warnings when building, some of
> > those have been fixed in that series, some of them are discarded in
> > CFLAGS as explained in the Android.bp addition patch.
> > 
> > The series has been successfully tested on Boundary Devices Nitrogen
> > platforms with Android 11.
> > 
> > Let me know if you have any questions.
> > 
> > Changelog v1->v2:
> > - Add missing SPDX in Android.bp
> > 
> 
> Thanks - series is straightforward, thanks for cleanup, applied to -master !

Thanks for merging it so fast. However I saw that REUSE still isn't
happy as I added the license but it apparently requires copyright:
The following files have no copyright information:
* Android.bp

Sorry I thought that the SPDX-License-Identifier was sufficient. Let me
know if you want me to send a patch to add it.

Regards,
Gary
Stefano Babic March 8, 2022, 9:40 a.m. UTC | #3 
On 08.03.22 10:32, Gary Bisson wrote:
> Hi Stefano,
> 
> On Tue, Mar 08, 2022 at 10:22:05AM +0100, Stefano Babic wrote:
>> Hi Gary,
>>
>> On 08.03.22 09:53, Gary Bisson wrote:
>>> Hi,
>>>
>>> This series adds support to build libubootenv library as well
>>> fw_printenv/fw_setenv for Android.
>>>
>>> As Android uses the Bionic C library, it doesn't include index/rindex
>>> functions, so those have been changed to strchr/strrchr as recommended
>>> by the man page anyway (see first patch).
>>>
>>> As Android uses clang, it showed a few warnings when building, some of
>>> those have been fixed in that series, some of them are discarded in
>>> CFLAGS as explained in the Android.bp addition patch.
>>>
>>> The series has been successfully tested on Boundary Devices Nitrogen
>>> platforms with Android 11.
>>>
>>> Let me know if you have any questions.
>>>
>>> Changelog v1->v2:
>>> - Add missing SPDX in Android.bp
>>>
>>
>> Thanks - series is straightforward, thanks for cleanup, applied to -master !
> 
> Thanks for merging it so fast. However I saw that REUSE still isn't
> happy as I added the license but it apparently requires copyright:
> The following files have no copyright information:
> * Android.bp

Bad, pipeline has not sent an e-mail to me to inform. Yes, copyright is 
duty.

> 
> Sorry I thought that the SPDX-License-Identifier was sufficient. Let me
> know if you want me to send a patch to add it.

Please send a patch, thanks !

Best regards,
Stefano

> 
> Regards,
> Gary
>