| Message ID | 20191110194625.32119-1-adrian.freihofer@siemens.com |
|---|---|
| Headers | show |
| Series | swupdate: improve systemd config | expand |
Hi Adrian, On 10/11/19 20:46, Adrian Freihofer wrote: > Hi Stefano > > !!!!! This v6 is probably not ready for merging. It's not tested yet. !!!!!! > I'm sending this to get your opinion about the idea in general. > > Probably we should go one step back and remove the -sd / -sv packages again. > It seems simply not possible to provide one common binary package for a systemd > and a sysv based systems out of one DISTRO. The clean Yocto way is to have two > DISTROs; one configured with systemd and one configured with sysv. > > However, one more idea came to my mind, how we could get rid of the systemd > dependency, even if swupdate is built as part of a systemd enabled DISTRO. > We might add a second variant of the recipe. The second patch is a first proof > of concept implementation. Let me know if you have any concerns about the idea. > Otherwise I will test it further. > > Thank you for testing and merging v5. > I am quite unhappy with the current status. In fact, I get several broken build if systemd is not used. Several issues are due to the fact that install for services is now done directly in SWUpdate's Makefile, and it cannot know if they are used or not. For example, if systemd is not used and CONFIG_SYSTEMD_SYSTEM_UNITDIR is not set, I get error because SYSTEMD_SERVICE_swupdate is set and the service.socket is not found. This constrain to always set CONFIG_SYSTEMD_SYSTEM_UNITDID, but this is also nonsense. Should we not step back and move back the service units into recipes ? This is also what the most packages in OE are doing (service are in meta- and not in sources). Regarding your patches: I do not think that swupdate-rescue is a good idea. There is already a recipe for a rescue (swupdate-image) and it is impossible to have a defconfig working for any case. In some cases, it is not required to have a different configuration as productive systems, in some cases is strictly required. A generalization is not possible. Best regards, Stefano > Best regards, > Adrian > > Adrian Freihofer (2): > swupdate: back to init system specific packaging > swupdate-rescue: add separate package > > .../swupdate/{swupdate => files}/swupdate | 0 > recipes-support/swupdate/swupdate-rescue/defconfig | 100 +++++++++++++++++++++ > recipes-support/swupdate/swupdate-rescue_git.bb | 28 ++++++ > recipes-support/swupdate/swupdate.inc | 58 +++++------- > recipes-support/swupdate/swupdate_git.bb | 2 + > 5 files changed, 153 insertions(+), 35 deletions(-) > rename recipes-support/swupdate/{swupdate => files}/swupdate (100%) > create mode 100644 recipes-support/swupdate/swupdate-rescue/defconfig > create mode 100644 recipes-support/swupdate/swupdate-rescue_git.bb >
Hi Stefano !!!!! This v6 is probably not ready for merging. It's not tested yet. !!!!!! I'm sending this to get your opinion about the idea in general. Probably we should go one step back and remove the -sd / -sv packages again. It seems simply not possible to provide one common binary package for a systemd and a sysv based systems out of one DISTRO. The clean Yocto way is to have two DISTROs; one configured with systemd and one configured with sysv. However, one more idea came to my mind, how we could get rid of the systemd dependency, even if swupdate is built as part of a systemd enabled DISTRO. We might add a second variant of the recipe. The second patch is a first proof of concept implementation. Let me know if you have any concerns about the idea. Otherwise I will test it further. Thank you for testing and merging v5. Best regards, Adrian Adrian Freihofer (2): swupdate: back to init system specific packaging swupdate-rescue: add separate package .../swupdate/{swupdate => files}/swupdate | 0 recipes-support/swupdate/swupdate-rescue/defconfig | 100 +++++++++++++++++++++ recipes-support/swupdate/swupdate-rescue_git.bb | 28 ++++++ recipes-support/swupdate/swupdate.inc | 58 +++++------- recipes-support/swupdate/swupdate_git.bb | 2 + 5 files changed, 153 insertions(+), 35 deletions(-) rename recipes-support/swupdate/{swupdate => files}/swupdate (100%) create mode 100644 recipes-support/swupdate/swupdate-rescue/defconfig create mode 100644 recipes-support/swupdate/swupdate-rescue_git.bb