[02/12] arm: Add compile-time asserts for siginfo_t offsets

Message ID	20210503203814.25487-2-ebiederm@xmission.com
State	New
Headers	show Return-Path: <sparclinux-owner@vger.kernel.org> From: "Eric W. Beiderman" <ebiederm@xmission.com> To: Marco Elver <elver@google.com> Cc: Arnd Bergmann <arnd@arndb.de>, Florian Weimer <fweimer@redhat.com>, "David S. Miller" <davem@davemloft.net>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Peter Collingbourne <pcc@google.com>, Dmitry Vyukov <dvyukov@google.com>, Alexander Potapenko <glider@google.com>, sparclinux <sparclinux@vger.kernel.org>, linux-arch <linux-arch@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux API <linux-api@vger.kernel.org>, kasan-dev <kasan-dev@googlegroups.com>, "Eric W . Biederman" <ebiederm@xmission.com> Date: Mon, 3 May 2021 15:38:04 -0500 Message-Id: <20210503203814.25487-2-ebiederm@xmission.com> In-Reply-To: <20210503203814.25487-1-ebiederm@xmission.com> References: <m14kfjh8et.fsf_-_@fess.ebiederm.org> <20210503203814.25487-1-ebiederm@xmission.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 0.7 XMSubLong Long Subject * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa04 1397; Body=1 Fuz1=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject * 0.0 T_TooManySym_02 5+ unique symbols in subject parse: 1.06 (0.2%), extract_message_metadata: 12 (2.8%), get_uri_detail_list: 1.82 (0.4%), tests_pri_-1000: 13 (3.1%), tests_pri_-950: 1.26 (0.3%), tests_pri_-900: 1.06 (0.2%), tests_pri_-90: 82 (18.8%), check_bayes: 81 (18.4%), b_tokenize: 9 (1.9%), b_tok_get_all: 6 (1.5%), b_comp_prob: 2.1 (0.5%), b_tok_touch_all: 60 (13.8%), b_finish: 0.90 (0.2%), tests_pri_0: 294 (67.2%), check_dkim_signature: 1.00 (0.2%), check_dkim_adsp: 2.2 (0.5%), poll_dns_idle: 0.34 (0.1%), tests_pri_10: 2.5 (0.6%), tests_pri_500: 14 (3.2%), rewrite_mail: 0.00 (0.0%) Subject: [PATCH 02/12] arm: Add compile-time asserts for siginfo_t offsets Precedence: bulk
Series	signal: sort out si_trapno and si_perf \| expand [00/12] signal: sort out si_trapno and si_perf [01/12] sparc64: Add compile-time asserts for siginfo_t offsets [02/12] arm: Add compile-time asserts for siginfo_t offsets [03/12] arm64: Add compile-time asserts for siginfo_t offsets [04/12] siginfo: Move si_trapno inside the union inside _si_fault [05/12] signal: Implement SIL_FAULT_TRAPNO [06/12] signal: Use dedicated helpers to send signals with si_trapno set [07/12] signal: Remove __ARCH_SI_TRAPNO [08/12] signal: Rename SIL_PERF_EVENT SIL_FAULT_PERF_EVENT for consistency [09/12] signal: Factor force_sig_perf out of perf_sigtrap [10/12] signal: Redefine signinfo so 64bit fields are possible [11/12] signal: Deliver all of the siginfo perf data in _perf [12/12] signalfd: Remove SIL_FAULT_PERF_EVENT fields from signalfd_siginfo

Message ID

20210503203814.25487-2-ebiederm@xmission.com

State

New

Headers

From: "Eric W. Beiderman" <ebiederm@xmission.com>
To: Marco Elver <elver@google.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Florian Weimer <fweimer@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Collingbourne <pcc@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Alexander Potapenko <glider@google.com>,
        sparclinux <sparclinux@vger.kernel.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux API <linux-api@vger.kernel.org>,
        kasan-dev <kasan-dev@googlegroups.com>,
        "Eric W . Biederman" <ebiederm@xmission.com>
Date: Mon,  3 May 2021 15:38:04 -0500
Message-Id: <20210503203814.25487-2-ebiederm@xmission.com>
In-Reply-To: <20210503203814.25487-1-ebiederm@xmission.com>
References: <m14kfjh8et.fsf_-_@fess.ebiederm.org>
 <20210503203814.25487-1-ebiederm@xmission.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [PATCH 02/12] arm: Add compile-time asserts for siginfo_t offsets
Precedence: bulk

Series

signal: sort out si_trapno and si_perf | expand

Commit Message

Eric W. Biederman May 3, 2021, 8:38 p.m. UTC

From: Marco Elver <elver@google.com>

To help catch ABI breaks at compile-time, add compile-time assertions to
verify the siginfo_t layout.

This could have caught that we cannot portably add 64-bit integers to
siginfo_t on 32-bit architectures like Arm before reaching -next:
https://lkml.kernel.org/r/20210422191823.79012-1-elver@google.com

Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 arch/arm/kernel/signal.c | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c
index a3a38d0a4c85..2dac5d2c5cf6 100644
--- a/arch/arm/kernel/signal.c
+++ b/arch/arm/kernel/signal.c
@@ -725,3 +725,39 @@  asmlinkage void do_rseq_syscall(struct pt_regs *regs)
 	rseq_syscall(regs);
 }
 #endif
+
+/*
+ * Compile-time assertions for siginfo_t offsets. Check NSIG* as well, as
+ * changes likely come with new fields that should be added below.
+ */
+static_assert(NSIGILL	== 11);
+static_assert(NSIGFPE	== 15);
+static_assert(NSIGSEGV	== 9);
+static_assert(NSIGBUS	== 5);
+static_assert(NSIGTRAP	== 6);
+static_assert(NSIGCHLD	== 6);
+static_assert(NSIGSYS	== 2);
+static_assert(offsetof(siginfo_t, si_signo)	== 0x00);
+static_assert(offsetof(siginfo_t, si_errno)	== 0x04);
+static_assert(offsetof(siginfo_t, si_code)	== 0x08);
+static_assert(offsetof(siginfo_t, si_pid)	== 0x0c);
+static_assert(offsetof(siginfo_t, si_uid)	== 0x10);
+static_assert(offsetof(siginfo_t, si_tid)	== 0x0c);
+static_assert(offsetof(siginfo_t, si_overrun)	== 0x10);
+static_assert(offsetof(siginfo_t, si_status)	== 0x14);
+static_assert(offsetof(siginfo_t, si_utime)	== 0x18);
+static_assert(offsetof(siginfo_t, si_stime)	== 0x1c);
+static_assert(offsetof(siginfo_t, si_value)	== 0x14);
+static_assert(offsetof(siginfo_t, si_int)	== 0x14);
+static_assert(offsetof(siginfo_t, si_ptr)	== 0x14);
+static_assert(offsetof(siginfo_t, si_addr)	== 0x0c);
+static_assert(offsetof(siginfo_t, si_addr_lsb)	== 0x10);
+static_assert(offsetof(siginfo_t, si_lower)	== 0x14);
+static_assert(offsetof(siginfo_t, si_upper)	== 0x18);
+static_assert(offsetof(siginfo_t, si_pkey)	== 0x14);
+static_assert(offsetof(siginfo_t, si_perf)	== 0x10);
+static_assert(offsetof(siginfo_t, si_band)	== 0x0c);
+static_assert(offsetof(siginfo_t, si_fd)	== 0x10);
+static_assert(offsetof(siginfo_t, si_call_addr)	== 0x0c);
+static_assert(offsetof(siginfo_t, si_syscall)	== 0x10);
+static_assert(offsetof(siginfo_t, si_arch)	== 0x14);

[02/12] arm: Add compile-time asserts for siginfo_t offsets

Commit Message

Patch