diff mbox series

sparc: make xchg() into a statement expression

Message ID 20201020053328.17332-1-rdunlap@infradead.org
State New
Headers show
Series sparc: make xchg() into a statement expression | expand

Commit Message

Randy Dunlap Oct. 20, 2020, 5:33 a.m. UTC
Fix several of the same warning by using a GCC statement expression

../arch/sparc/include/asm/cmpxchg_32.h:28:22: warning: value computed is not used [-Wunused-value]
   28 | #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr))))

Passes sparc32 allmodconfig with no xchg warnings.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org
This is similar to a patch from Arnd for m68k:

 arch/sparc/include/asm/cmpxchg_32.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series


--- linux-next-20201009.orig/arch/sparc/include/asm/cmpxchg_32.h
+++ linux-next-20201009/arch/sparc/include/asm/cmpxchg_32.h
@@ -25,7 +25,7 @@  static inline unsigned long __xchg(unsig
 	return x;
-#define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr))))
+#define xchg(ptr,x) ({(__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr)));})
 /* Emulate cmpxchg() the same way we emulate atomics,
  * by hashing the object address and indexing into an array