| Message ID | 20180119132321.GA32694@mwanda |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [spark] sparc: vDSO: remove an extra tab | expand |
On 1/19/2018 5:23 AM, Dan Carpenter wrote: > This statement is indented one tab too far which is confusing and > leads to a Smatch warning: > > arch/sparc/vdso/vma.c:254 arch_setup_additional_pages() > warn: curly braces intended? > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/arch/sparc/vdso/vma.c b/arch/sparc/vdso/vma.c > index 0a6f50098e23..f51595f861b8 100644 > --- a/arch/sparc/vdso/vma.c > +++ b/arch/sparc/vdso/vma.c > @@ -251,7 +251,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp) > else > return map_vdso(&vdso_image_32_builtin, &vdso_mapping32); > #else > - return map_vdso(&vdso_image_64_builtin, &vdso_mapping64); > + return map_vdso(&vdso_image_64_builtin, &vdso_mapping64); > #endif > > } Should the subject be sparc instead of spark? Other than that, Reviewed-by: Nagarathnam Muthusamy <nagarathnam.muthusamy@oracle.com> Thanks! -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jan 19, 2018 at 10:09:44AM -0800, nagarathnam muthusamy wrote: > > Should the subject be sparc instead of spark? Other than that, > Stupid iphone auto corrects all my emails... Just kidding, I made that typo. Fortunately, that part doesn't get saved to the final git log. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Fri, 19 Jan 2018 21:19:39 +0300 > On Fri, Jan 19, 2018 at 10:09:44AM -0800, nagarathnam muthusamy wrote: >> >> Should the subject be sparc instead of spark? Other than that, >> > > Stupid iphone auto corrects all my emails... Just kidding, I made that > typo. Fortunately, that part doesn't get saved to the final git log. Applied, thanks :) -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/sparc/vdso/vma.c b/arch/sparc/vdso/vma.c index 0a6f50098e23..f51595f861b8 100644 --- a/arch/sparc/vdso/vma.c +++ b/arch/sparc/vdso/vma.c @@ -251,7 +251,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp) else return map_vdso(&vdso_image_32_builtin, &vdso_mapping32); #else - return map_vdso(&vdso_image_64_builtin, &vdso_mapping64); + return map_vdso(&vdso_image_64_builtin, &vdso_mapping64); #endif }
This statement is indented one tab too far which is confusing and leads to a Smatch warning: arch/sparc/vdso/vma.c:254 arch_setup_additional_pages() warn: curly braces intended? Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html