Message ID | 1451473761-30019-8-git-send-email-mst@redhat.com |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
I find it a little bit irritating when I receive a patch directly addressed to me to review, but I don't see the "00/34" cover letter. I want to see what this series is about, and what the motiviation for this change is. I'm also highly frustrated, in general, with mix-and-match CC: lists for patch series. Just put everyone relevant in the CC: for the entire series. That way I can easily inspect other parts of the series to see infrastructure buildup, and examples of other conversions or versions of the change. Thanks. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Dec 30, 2015 at 12:56:03PM -0500, David Miller wrote: > > I find it a little bit irritating when I receive a patch directly > addressed to me to review, but I don't see the "00/34" cover letter. > > I want to see what this series is about, and what the motiviation > for this change is. > > I'm also highly frustrated, in general, with mix-and-match CC: lists > for patch series. Just put everyone relevant in the CC: for the > entire series. That way I can easily inspect other parts of the > series to see infrastructure buildup, and examples of other > conversions or versions of the change. > > Thanks. Hi Dave. Sorry about that. The problem I had in the past is that vger rejects email with too many CC addresses. (It also rejected email with __smp_XXX in the subject suspecting it's spam :( ) I'll look for better solutions next time - for now, would it help if I bounced the whole patchset to you?
From: "Michael S. Tsirkin" <mst@redhat.com> Date: Wed, 30 Dec 2015 21:55:33 +0200 > The problem I had in the past is that vger rejects email with > too many CC addresses. I can't think of a patch set where a > 1024 character CC: list is legitimate anyways, even if all interested parties are included. > I'll look for better solutions next time - for now, would it help if I > bounced the whole patchset to you? Not necessary, I provided a reply to your 00/NN repost. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/sparc/include/asm/barrier_32.h b/arch/sparc/include/asm/barrier_32.h index ae69eda..8059130 100644 --- a/arch/sparc/include/asm/barrier_32.h +++ b/arch/sparc/include/asm/barrier_32.h @@ -1,7 +1,6 @@ #ifndef __SPARC_BARRIER_H #define __SPARC_BARRIER_H -#include <asm/processor.h> /* for nop() */ #include <asm-generic/barrier.h> #endif /* !(__SPARC_BARRIER_H) */ diff --git a/arch/sparc/include/asm/barrier_64.h b/arch/sparc/include/asm/barrier_64.h index 14a9286..26c3f72 100644 --- a/arch/sparc/include/asm/barrier_64.h +++ b/arch/sparc/include/asm/barrier_64.h @@ -37,25 +37,6 @@ do { __asm__ __volatile__("ba,pt %%xcc, 1f\n\t" \ #define rmb() __asm__ __volatile__("":::"memory") #define wmb() __asm__ __volatile__("":::"memory") -#define dma_rmb() rmb() -#define dma_wmb() wmb() - -#define smp_store_mb(__var, __value) \ - do { WRITE_ONCE(__var, __value); membar_safe("#StoreLoad"); } while(0) - -#ifdef CONFIG_SMP -#define smp_mb() mb() -#define smp_rmb() rmb() -#define smp_wmb() wmb() -#else -#define smp_mb() __asm__ __volatile__("":::"memory") -#define smp_rmb() __asm__ __volatile__("":::"memory") -#define smp_wmb() __asm__ __volatile__("":::"memory") -#endif - -#define read_barrier_depends() do { } while (0) -#define smp_read_barrier_depends() do { } while (0) - #define smp_store_release(p, v) \ do { \ compiletime_assert_atomic_type(*p); \ @@ -74,4 +55,6 @@ do { \ #define smp_mb__before_atomic() barrier() #define smp_mb__after_atomic() barrier() +#include <asm-generic/barrier.h> + #endif /* !(__SPARC64_BARRIER_H) */ diff --git a/arch/sparc/include/asm/processor.h b/arch/sparc/include/asm/processor.h index 2fe99e6..9da9646 100644 --- a/arch/sparc/include/asm/processor.h +++ b/arch/sparc/include/asm/processor.h @@ -5,7 +5,4 @@ #else #include <asm/processor_32.h> #endif - -#define nop() __asm__ __volatile__ ("nop") - #endif
On sparc 64 bit dma_rmb, dma_wmb, smp_store_mb, smp_mb, smp_rmb, smp_wmb, read_barrier_depends and smp_read_barrier_depends match the asm-generic variants exactly. Drop the local definitions and pull in asm-generic/barrier.h instead. nop uses __asm__ __volatile but is otherwise identical to the generic version, drop that as well. This is in preparation to refactoring this code area. Note: nop() was in processor.h and not in barrier.h as on other architectures. Nothing seems to depend on it being there though. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- arch/sparc/include/asm/barrier_32.h | 1 - arch/sparc/include/asm/barrier_64.h | 21 ++------------------- arch/sparc/include/asm/processor.h | 3 --- 3 files changed, 2 insertions(+), 23 deletions(-)