diff mbox

fix format string mismatch in arch/sparc/kernel/sysfs.c

Message ID 1400487991-8857-1-git-send-email-toralf.foerster@gmx.de
State Accepted
Delegated to: David Miller
Headers show

Commit Message

Toralf Förster May 19, 2014, 8:26 a.m. UTC
found by cppcheck

Signed-off-by: Toralf Förster <toralf.foerster@gmx.de>
---
 arch/sparc/kernel/sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sam Ravnborg May 19, 2014, 8:48 a.m. UTC | #1
On Mon, May 19, 2014 at 10:26:31AM +0200, Toralf Förster wrote:
> found by cppcheck
> 
> Signed-off-by: Toralf Förster <toralf.foerster@gmx.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>  arch/sparc/kernel/sysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/sparc/kernel/sysfs.c b/arch/sparc/kernel/sysfs.c
> index a364000..7f41d40 100644
> --- a/arch/sparc/kernel/sysfs.c
> +++ b/arch/sparc/kernel/sysfs.c
> @@ -151,7 +151,7 @@ static ssize_t store_mmustat_enable(struct device *s,
>  			size_t count)
>  {
>  	unsigned long val, err;
> -	int ret = sscanf(buf, "%ld", &val);
> +	int ret = sscanf(buf, "%lu", &val);
>  
>  	if (ret != 1)
>  		return -EINVAL;
> -- 
> 1.9.3
> 
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller May 21, 2014, 7:55 p.m. UTC | #2
From: Toralf Förster <toralf.foerster@gmx.de>
Date: Mon, 19 May 2014 10:26:31 +0200

> found by cppcheck
> 
> Signed-off-by: Toralf Förster <toralf.foerster@gmx.de>

Applied, thank you.

I adjusted your Subject line to have an appropriate subsystem
prefix, in this case "sparc64: "
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/sparc/kernel/sysfs.c b/arch/sparc/kernel/sysfs.c
index a364000..7f41d40 100644
--- a/arch/sparc/kernel/sysfs.c
+++ b/arch/sparc/kernel/sysfs.c
@@ -151,7 +151,7 @@  static ssize_t store_mmustat_enable(struct device *s,
 			size_t count)
 {
 	unsigned long val, err;
-	int ret = sscanf(buf, "%ld", &val);
+	int ret = sscanf(buf, "%lu", &val);
 
 	if (ret != 1)
 		return -EINVAL;