From patchwork Fri Jun 23 05:56:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexey Kardashevskiy X-Patchwork-Id: 779802 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wv74v0W47z9ryQ for ; Fri, 23 Jun 2017 15:57:03 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ozlabs-ru.20150623.gappssmtp.com header.i=@ozlabs-ru.20150623.gappssmtp.com header.b="EFPcd5Yg"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3wv74t6WGjzDqjv for ; Fri, 23 Jun 2017 15:57:02 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ozlabs-ru.20150623.gappssmtp.com header.i=@ozlabs-ru.20150623.gappssmtp.com header.b="EFPcd5Yg"; dkim-atps=neutral X-Original-To: slof@lists.ozlabs.org Delivered-To: slof@lists.ozlabs.org Received: from mail-it0-x232.google.com (mail-it0-x232.google.com [IPv6:2607:f8b0:4001:c0b::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3wv74q0BvRzDqjM for ; Fri, 23 Jun 2017 15:56:58 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ozlabs-ru.20150623.gappssmtp.com header.i=@ozlabs-ru.20150623.gappssmtp.com header.b="EFPcd5Yg"; dkim-atps=neutral Received: by mail-it0-x232.google.com with SMTP id b205so2940340itg.1 for ; Thu, 22 Jun 2017 22:56:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ozlabs-ru.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uKujCx3bNfsQi9pUasC1RMnslJ12hq422+ndiAZ9iQI=; b=EFPcd5YgWgO4v56iC20MN/CCcRQJpE/CyGggCCsErkuKHf7VFE1oA+84ch4C4cs0Hr xa8ziAjNNI0zeTYls1vRFu5o/JVKgbDGndcZawzdc+X/MAEasjTTHCEiAzc7jLoAcsyQ jYZze2fT47CNMRlYgt4hR1bWS/jOyF8dPQWFS76MGHbWecv37G5GA5z3CG55J8PwN80c +LFYhNP3suO9qw0tKR0xWm2y8F/bhKvb+pTGGdYpMsCspRHx/h+2PsKULtz4cXpJqWfk bsoNizkF/bpdUhuISqzG+XSdH4o0vDgH8zkRGEWwuGGV+/TuMXLnZseYlzvJ/tgBB0C6 q67g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uKujCx3bNfsQi9pUasC1RMnslJ12hq422+ndiAZ9iQI=; b=U5ZKCbMa8NpkFRw3f9t7PxlVVZEoxuoMMRpYP+3q+xe1B639HR6imci6IiBQlP11ic TGXIQAS8xjrskLytEjRWlPD32YmFYd2pSS0CqjhPs5s35srEhdFqu1Pgs1d6E8h27Vs7 cmwuE6E1OkVnlyXzQQ5CFkc+4E7kkYtZsusa6b+vlnfDvK15nQ/yCnwLvVtkir4nX5tm LTB/pHnh7qryraV0cBxJowjxNNrcqQPAEtaEK0JlZE3IF4kajZDZXJkHM4EUb5Wg7lzS xWBLrzLj8OthF+L/8GEFC7h4fRMv/AqjCCjRmL/Bd7UFZP8CsNTUFsiXFaRgGFzjiey+ 7ZfQ== X-Gm-Message-State: AKS2vOzXYZUxoJXIs4bPGNEZykWFR9VwfZj0a7S6KDm0jR6bi3DfOH+Q 1nAjqo5cgd6Wgn3tYCo= X-Received: by 10.36.172.84 with SMTP id m20mr5378075iti.119.1498197415754; Thu, 22 Jun 2017 22:56:55 -0700 (PDT) Received: from [10.61.2.175] ([122.99.82.10]) by smtp.googlemail.com with ESMTPSA id i73sm2334514ioi.30.2017.06.22.22.56.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jun 2017 22:56:55 -0700 (PDT) To: Segher Boessenkool , =?UTF-8?Q?Murilo_Opsfelder_Ara=c3=bajo?= References: <20170622204001.GI16550@gate.crashing.org> <42872123-c175-e72b-7a88-f2f37a6193ec@linux.vnet.ibm.com> <20170622212111.GJ16550@gate.crashing.org> From: Alexey Kardashevskiy Message-ID: Date: Fri, 23 Jun 2017 15:56:51 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170622212111.GJ16550@gate.crashing.org> Content-Language: en-AU Subject: Re: [SLOF] FLAG is not passed correctly to the compiler X-BeenThere: slof@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Patches for https://github.com/aik/SLOF" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: slof@lists.ozlabs.org Errors-To: slof-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "SLOF" On 23/06/17 07:21, Segher Boessenkool wrote: > On Thu, Jun 22, 2017 at 05:51:13PM -0300, Murilo Opsfelder Araújo wrote: >>> What is the actual command that causes the problem? It isn't clear >>> to me from your mail. >> >> Here are some extracts from a slof build (make qemu V=2): > > Ah, board-qemu/config is written as if it is a shell script; it is > not, it is a makefile fragment. Simply remove the quotes there? Then it fails in a different place: [vpl2 slof]$ make qemu V=2 ******** Building qemu system ******** make[1]: Entering directory '/home/aik/p/slof/board-qemu' make -C ../tools make[2]: Entering directory '/home/aik/p/slof/tools' gcc -W -g -Wall -W -O2 -I. -I../include -I../romfs/tools -c gen_reloc_table.c gcc -g -Wall -W -O2 -I. -I../include -I../romfs/tools -o gen_reloc_table gen_reloc_table.o gcc -W -g -Wall -W -O2 -I. -I../include -I../romfs/tools -c sloffs.c gcc -W -g -Wall -W -O2 -I. -I../include -I../romfs/tools -c ../romfs/tools/crclib.c -o crclib.o gcc -g -Wall -W -O2 -I. -I../include -I../romfs/tools -o sloffs sloffs.o crclib.o make[2]: Leaving directory '/home/aik/p/slof/tools' make -C ../romfs/tools BOARD=qemu PLATFORM= FLAG=-DRTAS_NVRAM -DBROKEN_SC1 -DDHCPARCH=0x0C TARG=ppc64 make: invalid option -- 'D' make: invalid option -- 'D' make: invalid option -- 'D' make: invalid option -- 'H' Usage: make [options] [target] ... Options: afaict this fixes the original issue: Murilo, please give it a try. In general, lib/**/Makefile could use some cleanup - they all define ASFLAGS/CPPFLAGS/LDFLAGS, mostly identical, when it is not identical, it feels like just by oversight than anything else. > > > Segher > _______________________________________________ > SLOF mailing list > SLOF@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/slof > diff --git a/lib/Makefile b/lib/Makefile index a4d4bb2..1e8bb62 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -21,7 +21,7 @@ all: subdirs subdirs: $(SUBDIRS) $(SUBDIRS): - $(MAKE) -C $@ $(MAKEARG) + $(MAKE) -C $@ FLAG=$(FLAG) $(MAKEARG) # Rules for making clean: clean: