diff mbox series

board-qemu: Fix comment about SLOF start address

Message ID 1592858893-30293-1-git-send-email-gromero@linux.ibm.com
State New
Headers show
Series board-qemu: Fix comment about SLOF start address | expand

Commit Message

Gustavo Romero June 22, 2020, 8:48 p.m. UTC
On QEMU pseries (and alike environments) the PC starts at 0x100, hence SLOF
starts at address 0x100, not at 0x0 as the current comment informs. After
that fix the comment also matches the comment above it about the __start
load position, which is correct.

Signed-off-by: Gustavo Romero <gromero@linux.ibm.com>
---
 board-qemu/llfw/startup.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexey Kardashevskiy June 24, 2020, 12:31 a.m. UTC | #1
On 23/06/2020 06:48, Gustavo Romero wrote:
> On QEMU pseries (and alike environments) the PC starts at 0x100, hence SLOF
> starts at address 0x100, not at 0x0 as the current comment informs. After
> that fix the comment also matches the comment above it about the __start
> load position, which is correct.
> 
> Signed-off-by: Gustavo Romero <gromero@linux.ibm.com>


Thanks, applied.


> ---
>  board-qemu/llfw/startup.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board-qemu/llfw/startup.S b/board-qemu/llfw/startup.S
> index bbd3ce3..96cbb3e 100644
> --- a/board-qemu/llfw/startup.S
> +++ b/board-qemu/llfw/startup.S
> @@ -22,7 +22,7 @@
>  	 *
>  	 * __start loaded at 0x100
>  	 *
> -	 * CPU 0 starts at 0 with GPR3 pointing to the flat devtree
> +	 * CPU 0 starts at 0x100 with GPR3 pointing to the flat devtree
>  	 *
>  	 * All other CPUs are held in stopped state by qemu and are
>  	 * started via RTAS
>
diff mbox series

Patch

diff --git a/board-qemu/llfw/startup.S b/board-qemu/llfw/startup.S
index bbd3ce3..96cbb3e 100644
--- a/board-qemu/llfw/startup.S
+++ b/board-qemu/llfw/startup.S
@@ -22,7 +22,7 @@ 
 	 *
 	 * __start loaded at 0x100
 	 *
-	 * CPU 0 starts at 0 with GPR3 pointing to the flat devtree
+	 * CPU 0 starts at 0x100 with GPR3 pointing to the flat devtree
 	 *
 	 * All other CPUs are held in stopped state by qemu and are
 	 * started via RTAS