From patchwork Thu Jul 13 22:25:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kurz X-Patchwork-Id: 788016 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3x7rs34PGpz9s8V for ; Fri, 14 Jul 2017 09:00:55 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3x7rs30zjkzDqlR for ; Fri, 14 Jul 2017 09:00:55 +1000 (AEST) X-Original-To: slof@lists.ozlabs.org Delivered-To: slof@lists.ozlabs.org Received: from 8.mo173.mail-out.ovh.net (8.mo173.mail-out.ovh.net [46.105.46.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3x7rrz5v4FzDqlR for ; Fri, 14 Jul 2017 09:00:51 +1000 (AEST) Received: from player687.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo173.mail-out.ovh.net (Postfix) with ESMTP id CD7C967305 for ; Fri, 14 Jul 2017 00:25:16 +0200 (CEST) Received: from bahia.lan (gar31-1-82-66-74-139.fbx.proxad.net [82.66.74.139]) (Authenticated sender: groug@kaod.org) by player687.ha.ovh.net (Postfix) with ESMTPA id 99D032C0073; Fri, 14 Jul 2017 00:25:14 +0200 (CEST) From: Greg Kurz To: slof@lists.ozlabs.org Date: Fri, 14 Jul 2017 00:25:14 +0200 Message-ID: <149998471438.13629.17597725105451052140.stgit@bahia.lan> In-Reply-To: <149998470010.13629.16124878075303408145.stgit@bahia.lan> References: <149998470010.13629.16124878075303408145.stgit@bahia.lan> User-Agent: StGit/0.17.1-20-gc0b1b-dirty MIME-Version: 1.0 X-Ovh-Tracer-Id: 17531387453734623538 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeelkedrfedvgddukecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Subject: [SLOF] [PATCH v2 1/3] board_qemu: drop unused values early in fdt-fix-node-phandle X-BeenThere: slof@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Patches for https://github.com/aik/SLOF" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth Errors-To: slof-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "SLOF" These two values are pushed on the stack by decode-int and stay unused until the 2drop line. Let's drop them right away to make it obvious. Signed-off-by: Greg Kurz --- board-qemu/slof/fdt.fs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/board-qemu/slof/fdt.fs b/board-qemu/slof/fdt.fs index 8d4635f30495..eff3375c5916 100644 --- a/board-qemu/slof/fdt.fs +++ b/board-qemu/slof/fdt.fs @@ -314,11 +314,10 @@ fdt-claim-reserve >r FALSE TO (fdt-phandle-replaced) s" phandle" r@ get-property 0= IF - decode-int ( p-addr2 p-len2 val ) + decode-int -rot 2drop \ ." found phandle: " dup . cr - r@ s" /" find-node ( p-addr2 p-len2 val node root ) - fdt-replace-all-phandles ( p-addr2 p-len2 ) - 2drop + r@ s" /" find-node ( val node root ) + fdt-replace-all-phandles (fdt-phandle-replaced) IF r@ set-node s" phandle" delete-property