From patchwork Thu Jul 13 13:07:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 787718 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3x7bhx4LN3z9ryk for ; Thu, 13 Jul 2017 23:08:01 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3x7bhx1yCczDqkL for ; Thu, 13 Jul 2017 23:08:01 +1000 (AEST) X-Original-To: slof@lists.ozlabs.org Delivered-To: slof@lists.ozlabs.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3x7bhs55sdzDqk6 for ; Thu, 13 Jul 2017 23:07:57 +1000 (AEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B29CF3F741; Thu, 13 Jul 2017 13:07:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B29CF3F741 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=thuth@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B29CF3F741 Received: from thh440s.str.redhat.com (dhcp-200-180.str.redhat.com [10.33.200.180]) by smtp.corp.redhat.com (Postfix) with ESMTP id 141B56C50D; Thu, 13 Jul 2017 13:07:54 +0000 (UTC) From: Thomas Huth To: slof@lists.ozlabs.org Date: Thu, 13 Jul 2017 15:07:54 +0200 Message-Id: <1499951274-25709-1-git-send-email-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 13 Jul 2017 13:07:55 +0000 (UTC) Subject: [SLOF] [PATCH] pci: Translate PCI addresses to host addresses at the end of map-in X-BeenThere: slof@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Patches for https://github.com/aik/SLOF" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: slof-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "SLOF" Currently, it is not possible to use VGA devices attached to a PCI bridge on board-qemu, e.g. by starting QEMU like this: qemu-system-ppc64 -nodefaults -device pci-bridge,id=br1,chassis_nr=1 \ -serial mon:stdio -device VGA,id=video,bus=br1,addr=1 One of the problems is the missing translate-address at the end of the map-in function of the bridge - which was already marked as a TODO, but apparently has never been enabled. So let's do that now! Signed-off-by: Thomas Huth --- slof/fs/pci-config-bridge.fs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slof/fs/pci-config-bridge.fs b/slof/fs/pci-config-bridge.fs index 1efbcd8..4169aa8 100644 --- a/slof/fs/pci-config-bridge.fs +++ b/slof/fs/pci-config-bridge.fs @@ -73,7 +73,7 @@ nip THEN F NOT AND \ Clear indicator bits - \ TODO: Use translate-address here! + translate-my-address ; : map-out ( virt size -- )