diff mbox

[1/2] libhvcall: drop unused KVMPPC_H_REPORT_MC_ERR and KVMPPC_H_NMI_MCE defines

Message ID 149968906629.10573.8711303086238751224.stgit@bahia.lan
State Accepted
Headers show

Commit Message

Greg Kurz July 10, 2017, 12:17 p.m. UTC
These defines were introduced to add support for FWNMI in KVM guests. This
has been WIP since 2015 and the KVM part finally made it to kvm-ppc-next.

Latest work on the QEMU side [1] no longer needs KVMPPC_H_REPORT_MC_ERR.
The KVMPPC_HCALL_MAX define is never used anywhere, and moreover it
is bogus since there's no KVMPPC_H_NMI_MCE private hcall.

[1] http://lists.nongnu.org/archive/html/qemu-ppc/2015-12/msg00199.html

Signed-off-by: Greg Kurz <groug@kaod.org>
---
 lib/libhvcall/libhvcall.h |    2 --
 1 file changed, 2 deletions(-)

Comments

Thomas Huth July 10, 2017, 2:44 p.m. UTC | #1
On 10.07.2017 14:17, Greg Kurz wrote:
> These defines were introduced to add support for FWNMI in KVM guests. This
> has been WIP since 2015 and the KVM part finally made it to kvm-ppc-next.
> 
> Latest work on the QEMU side [1] no longer needs KVMPPC_H_REPORT_MC_ERR.
> The KVMPPC_HCALL_MAX define is never used anywhere, and moreover it
> is bogus since there's no KVMPPC_H_NMI_MCE private hcall.
> 
> [1] http://lists.nongnu.org/archive/html/qemu-ppc/2015-12/msg00199.html
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>  lib/libhvcall/libhvcall.h |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/lib/libhvcall/libhvcall.h b/lib/libhvcall/libhvcall.h
> index 193b7383dd36..b2ea3f6bf944 100644
> --- a/lib/libhvcall/libhvcall.h
> +++ b/lib/libhvcall/libhvcall.h
> @@ -25,8 +25,6 @@
>  /* Client Architecture support */
>  #define KVMPPC_H_CAS            (KVMPPC_HCALL_BASE + 0x2)
>  #define KVMPPC_H_RTAS_UPDATE    (KVMPPC_HCALL_BASE + 0x3)
> -#define KVMPPC_H_REPORT_MC_ERR  (KVMPPC_HCALL_BASE + 0x4)
> -#define KVMPPC_HCALL_MAX        KVMPPC_H_NMI_MCE
>  
>  #ifndef __ASSEMBLY__

Reviewed-by: Thomas Huth <thuth@redhat.com>
Alexey Kardashevskiy July 11, 2017, 4:35 a.m. UTC | #2
On 10/07/17 22:17, Greg Kurz wrote:
> These defines were introduced to add support for FWNMI in KVM guests. This
> has been WIP since 2015 and the KVM part finally made it to kvm-ppc-next.
> 
> Latest work on the QEMU side [1] no longer needs KVMPPC_H_REPORT_MC_ERR.
> The KVMPPC_HCALL_MAX define is never used anywhere, and moreover it
> is bogus since there's no KVMPPC_H_NMI_MCE private hcall.
> 
> [1] http://lists.nongnu.org/archive/html/qemu-ppc/2015-12/msg00199.html
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>

Thanks, I applied this one.


> ---
>  lib/libhvcall/libhvcall.h |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/lib/libhvcall/libhvcall.h b/lib/libhvcall/libhvcall.h
> index 193b7383dd36..b2ea3f6bf944 100644
> --- a/lib/libhvcall/libhvcall.h
> +++ b/lib/libhvcall/libhvcall.h
> @@ -25,8 +25,6 @@
>  /* Client Architecture support */
>  #define KVMPPC_H_CAS            (KVMPPC_HCALL_BASE + 0x2)
>  #define KVMPPC_H_RTAS_UPDATE    (KVMPPC_HCALL_BASE + 0x3)
> -#define KVMPPC_H_REPORT_MC_ERR  (KVMPPC_HCALL_BASE + 0x4)
> -#define KVMPPC_HCALL_MAX        KVMPPC_H_NMI_MCE
>  
>  #ifndef __ASSEMBLY__
>  
> 
> _______________________________________________
> SLOF mailing list
> SLOF@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/slof
>
diff mbox

Patch

diff --git a/lib/libhvcall/libhvcall.h b/lib/libhvcall/libhvcall.h
index 193b7383dd36..b2ea3f6bf944 100644
--- a/lib/libhvcall/libhvcall.h
+++ b/lib/libhvcall/libhvcall.h
@@ -25,8 +25,6 @@ 
 /* Client Architecture support */
 #define KVMPPC_H_CAS            (KVMPPC_HCALL_BASE + 0x2)
 #define KVMPPC_H_RTAS_UPDATE    (KVMPPC_HCALL_BASE + 0x3)
-#define KVMPPC_H_REPORT_MC_ERR  (KVMPPC_HCALL_BASE + 0x4)
-#define KVMPPC_HCALL_MAX        KVMPPC_H_NMI_MCE
 
 #ifndef __ASSEMBLY__