| Message ID | 1496766701-30411-1-git-send-email-thuth@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
On 07/06/17 02:31, Thomas Huth wrote: > It's not obvious for the normal user why the alias enumeration should > stop at the digit '7' already, so let's allow '8' and '9', too, by > bumping the MAX-ALIAS constant to 10. Also remove the unnecessary > duplicate of this value from qemu-bootlist.fs. Thanks, applied. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > board-qemu/slof/qemu-bootlist.fs | 1 - > slof/fs/node.fs | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/board-qemu/slof/qemu-bootlist.fs b/board-qemu/slof/qemu-bootlist.fs > index 60dd29d..6a4005d 100644 > --- a/board-qemu/slof/qemu-bootlist.fs > +++ b/board-qemu/slof/qemu-bootlist.fs > @@ -13,7 +13,6 @@ > defer set-boot-device > defer add-boot-device > > -8 CONSTANT MAX-ALIAS > : add-boot-aliases ( str -- ) > 2dup add-boot-device ( $str ) > MAX-ALIAS 1 DO > diff --git a/slof/fs/node.fs b/slof/fs/node.fs > index 22bf77b..3b079e4 100644 > --- a/slof/fs/node.fs > +++ b/slof/fs/node.fs > @@ -324,7 +324,7 @@ defer find-node > > \ return next available name for aliasing or > \ false if more than MAX-ALIAS aliases found > -8 CONSTANT MAX-ALIAS > +d# 10 CONSTANT MAX-ALIAS > 1 VALUE alias-ind > : get-next-alias ( $alias-name -- $next-alias-name|FALSE ) > 2dup find-alias IF >
diff --git a/board-qemu/slof/qemu-bootlist.fs b/board-qemu/slof/qemu-bootlist.fs index 60dd29d..6a4005d 100644 --- a/board-qemu/slof/qemu-bootlist.fs +++ b/board-qemu/slof/qemu-bootlist.fs @@ -13,7 +13,6 @@ defer set-boot-device defer add-boot-device -8 CONSTANT MAX-ALIAS : add-boot-aliases ( str -- ) 2dup add-boot-device ( $str ) MAX-ALIAS 1 DO diff --git a/slof/fs/node.fs b/slof/fs/node.fs index 22bf77b..3b079e4 100644 --- a/slof/fs/node.fs +++ b/slof/fs/node.fs @@ -324,7 +324,7 @@ defer find-node \ return next available name for aliasing or \ false if more than MAX-ALIAS aliases found -8 CONSTANT MAX-ALIAS +d# 10 CONSTANT MAX-ALIAS 1 VALUE alias-ind : get-next-alias ( $alias-name -- $next-alias-name|FALSE ) 2dup find-alias IF
It's not obvious for the normal user why the alias enumeration should stop at the digit '7' already, so let's allow '8' and '9', too, by bumping the MAX-ALIAS constant to 10. Also remove the unnecessary duplicate of this value from qemu-bootlist.fs. Signed-off-by: Thomas Huth <thuth@redhat.com> --- board-qemu/slof/qemu-bootlist.fs | 1 - slof/fs/node.fs | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)