| Message ID | 1494355502-32292-1-git-send-email-thuth@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
On 10/05/17 04:45, Thomas Huth wrote: > The next-pci-mem and next-pci-mmio Forth words are completely unused, > and pci-next-io is only used in one location (which can easily be > replaced), so let's get simply rid of these legacy functions. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Thanks, applied. > --- > board-js2x/slof/pci-bridge_1022_7460.fs | 2 +- > slof/fs/pci-scan.fs | 7 ------- > 2 files changed, 1 insertion(+), 8 deletions(-) > > diff --git a/board-js2x/slof/pci-bridge_1022_7460.fs b/board-js2x/slof/pci-bridge_1022_7460.fs > index 87b5830..67fe64e 100644 > --- a/board-js2x/slof/pci-bridge_1022_7460.fs > +++ b/board-js2x/slof/pci-bridge_1022_7460.fs > @@ -81,7 +81,7 @@ INCLUDE freq.fs > 0 8a0 config-l! > > \ 8111 has only 16 bits of PCI I/O space. Get the address in range. > -8000 next-pci-io ! > +8000 pci-next-io ! > > \ before disabling EHCI it needs to be reset > > diff --git a/slof/fs/pci-scan.fs b/slof/fs/pci-scan.fs > index bd8cc0d..c0dbbed 100644 > --- a/slof/fs/pci-scan.fs > +++ b/slof/fs/pci-scan.fs > @@ -44,13 +44,6 @@ here 100 allot CONSTANT pci-device-vec > \ enable/disable creation of hotplug-specific properties > 0 VALUE pci-hotplug-enabled > > - > -\ Fixme Glue to the pci-devices ... remove this later > -: next-pci-mem ( addr -- addr ) pci-next-mem ; > -: next-pci-mmio ( addr -- addr ) pci-next-mmio ; > -: next-pci-io ( addr -- addr ) pci-next-io ; > - > - > #include "pci-helper.fs" > > \ Dump out the pci device-slot vector >
diff --git a/board-js2x/slof/pci-bridge_1022_7460.fs b/board-js2x/slof/pci-bridge_1022_7460.fs index 87b5830..67fe64e 100644 --- a/board-js2x/slof/pci-bridge_1022_7460.fs +++ b/board-js2x/slof/pci-bridge_1022_7460.fs @@ -81,7 +81,7 @@ INCLUDE freq.fs 0 8a0 config-l! \ 8111 has only 16 bits of PCI I/O space. Get the address in range. -8000 next-pci-io ! +8000 pci-next-io ! \ before disabling EHCI it needs to be reset diff --git a/slof/fs/pci-scan.fs b/slof/fs/pci-scan.fs index bd8cc0d..c0dbbed 100644 --- a/slof/fs/pci-scan.fs +++ b/slof/fs/pci-scan.fs @@ -44,13 +44,6 @@ here 100 allot CONSTANT pci-device-vec \ enable/disable creation of hotplug-specific properties 0 VALUE pci-hotplug-enabled - -\ Fixme Glue to the pci-devices ... remove this later -: next-pci-mem ( addr -- addr ) pci-next-mem ; -: next-pci-mmio ( addr -- addr ) pci-next-mmio ; -: next-pci-io ( addr -- addr ) pci-next-io ; - - #include "pci-helper.fs" \ Dump out the pci device-slot vector
The next-pci-mem and next-pci-mmio Forth words are completely unused, and pci-next-io is only used in one location (which can easily be replaced), so let's get simply rid of these legacy functions. Signed-off-by: Thomas Huth <thuth@redhat.com> --- board-js2x/slof/pci-bridge_1022_7460.fs | 2 +- slof/fs/pci-scan.fs | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-)