| Message ID | 1493115697-11835-1-git-send-email-thuth@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
On 25/04/2017 12:21, Thomas Huth wrote: > The current SLOF logo ASCII art is rather hard to read and also looks > rather ugly in my opinion. Replace it with another ASCII art that is > more readable. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > BTW, maybe we should rather get rid of the logo completely instead? > Does it still make sense to waste precious boot cycles with this nowadays? IMHO, I think we should get rid of it. A logo is fun at the beginning and then we want simplicity. It can also help to parse console output with automated test tools to have "normal" output. Thanks, Laurent
On 25/04/17 20:21, Thomas Huth wrote: > The current SLOF logo ASCII art is rather hard to read and also looks > rather ugly in my opinion. Replace it with another ASCII art that is > more readable. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > BTW, maybe we should rather get rid of the logo completely instead? I can imagine someone having an expect script which waits for this exact logo. > Does it still make sense to waste precious boot cycles with this nowadays? How much does it save? > > slof/fs/slof-logo.fs | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/slof/fs/slof-logo.fs b/slof/fs/slof-logo.fs > index 53d3184..8627109 100644 > --- a/slof/fs/slof-logo.fs > +++ b/slof/fs/slof-logo.fs > @@ -11,10 +11,10 @@ > \ ****************************************************************************/ > > : .slof-logo > - cr ." ..`. .. ....... .. ...... ......." > - cr ." ..`...`''.`'. .''``````..''. .`''```''`. `''``````" > - cr ." .`` .:' ': `''..... .''. ''` .''..''......." > - cr ." ``.':.';. ``````''`.''. .''. ''``''`````'`" > - cr ." ``.':':` .....`''.`'`...... `'`.....`''.`'` " > - cr ." .`.`'`` .'`'`````. ``'''''' ``''`'''`. `'` " > + ." _____ _ ____ _____ " cr > + ." / ____| | / __ \| ___|" cr > + ." | (___ | | | | | | |__ " cr > + ." \___ \| | | | | | __| " cr > + ." ____) | |__| |__| | | " cr > + ." |_____/|_____\____/|_| - Slimline Open Firmware" cr > ; >
On 25.04.2017 15:35, Alexey Kardashevskiy wrote: > On 25/04/17 20:21, Thomas Huth wrote: >> The current SLOF logo ASCII art is rather hard to read and also looks >> rather ugly in my opinion. Replace it with another ASCII art that is >> more readable. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> >> --- >> BTW, maybe we should rather get rid of the logo completely instead? > > I can imagine someone having an expect script which waits for this exact logo. That sounds sick. In that case, it's time to update their expect scripts. >> Does it still make sense to waste precious boot cycles with this nowadays? > > How much does it save? With VGA enabled: milliseconds .slof-logo milliseconds swap - .d ==> 660 milliseconds Printing the logo is just a waste of time and space on the screen. Or do you really like it and want to keep it? Thomas
On Tue, Apr 25, 2017 at 04:26:40PM +0200, Thomas Huth wrote: > On 25.04.2017 15:35, Alexey Kardashevskiy wrote: > > On 25/04/17 20:21, Thomas Huth wrote: > >> The current SLOF logo ASCII art is rather hard to read and also looks > >> rather ugly in my opinion. Replace it with another ASCII art that is > >> more readable. > >> > >> Signed-off-by: Thomas Huth <thuth@redhat.com> > >> --- > >> BTW, maybe we should rather get rid of the logo completely instead? > > > > I can imagine someone having an expect script which waits for this exact logo. > > That sounds sick. In that case, it's time to update their expect scripts. > > >> Does it still make sense to waste precious boot cycles with this nowadays? > > > > How much does it save? > > With VGA enabled: > > milliseconds .slof-logo milliseconds swap - .d > > ==> 660 milliseconds Wow, that's pretty bad. > Printing the logo is just a waste of time and space on the screen. Or do > you really like it and want to keep it? > > Thomas > > _______________________________________________ > SLOF mailing list > SLOF@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/slof
On Tue, Apr 25, 2017 at 04:26:40PM +0200, Thomas Huth wrote: > >> Does it still make sense to waste precious boot cycles with this nowadays? > > > > How much does it save? > > With VGA enabled: > > milliseconds .slof-logo milliseconds swap - .d > > ==> 660 milliseconds That just means the VGA code is extremely slow. Even on a slow serial line it would be only 100ms or so max ;-) Segher
Thomas Huth <thuth@redhat.com> writes: > On 25.04.2017 15:35, Alexey Kardashevskiy wrote: >> On 25/04/17 20:21, Thomas Huth wrote: >>> The current SLOF logo ASCII art is rather hard to read and also looks >>> rather ugly in my opinion. Replace it with another ASCII art that is >>> more readable. >>> >>> Signed-off-by: Thomas Huth <thuth@redhat.com> >>> --- >>> BTW, maybe we should rather get rid of the logo completely instead? >> >> I can imagine someone having an expect script which waits for this exact logo. > > That sounds sick. In that case, it's time to update their expect scripts. > >>> Does it still make sense to waste precious boot cycles with this nowadays? >> >> How much does it save? > > With VGA enabled: > > milliseconds .slof-logo milliseconds swap - .d > > ==> 660 milliseconds > > Printing the logo is just a waste of time and space on the screen. Or do > you really like it and want to keep it? I would vote to get rid of the ASCII art, and just print a simple string with version info. BTW, Seabios does not have any visible print during booting. Regards, Nikunj
diff --git a/slof/fs/slof-logo.fs b/slof/fs/slof-logo.fs index 53d3184..8627109 100644 --- a/slof/fs/slof-logo.fs +++ b/slof/fs/slof-logo.fs @@ -11,10 +11,10 @@ \ ****************************************************************************/ : .slof-logo - cr ." ..`. .. ....... .. ...... ......." - cr ." ..`...`''.`'. .''``````..''. .`''```''`. `''``````" - cr ." .`` .:' ': `''..... .''. ''` .''..''......." - cr ." ``.':.';. ``````''`.''. .''. ''``''`````'`" - cr ." ``.':':` .....`''.`'`...... `'`.....`''.`'` " - cr ." .`.`'`` .'`'`````. ``'''''' ``''`'''`. `'` " + ." _____ _ ____ _____ " cr + ." / ____| | / __ \| ___|" cr + ." | (___ | | | | | | |__ " cr + ." \___ \| | | | | | __| " cr + ." ____) | |__| |__| | | " cr + ." |_____/|_____\____/|_| - Slimline Open Firmware" cr ;
The current SLOF logo ASCII art is rather hard to read and also looks rather ugly in my opinion. Replace it with another ASCII art that is more readable. Signed-off-by: Thomas Huth <thuth@redhat.com> --- BTW, maybe we should rather get rid of the logo completely instead? Does it still make sense to waste precious boot cycles with this nowadays? slof/fs/slof-logo.fs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)