From patchwork Wed Aug 11 05:48:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1515588 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=aFeUF1YB; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GkzR01kwTz9sWS for ; Wed, 11 Aug 2021 15:49:16 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GkzR00b2qz30Qn for ; Wed, 11 Aug 2021 15:49:16 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=aFeUF1YB; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::633; helo=mail-pl1-x633.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=aFeUF1YB; dkim-atps=neutral Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GkzQm1ztjz30JK for ; Wed, 11 Aug 2021 15:49:04 +1000 (AEST) Received: by mail-pl1-x633.google.com with SMTP id e19so1223444pla.10 for ; Tue, 10 Aug 2021 22:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZvFNfOtUNKQ7IKH3hFaEEj1f0tiENCiQ1lG+S/iP8QI=; b=aFeUF1YBuqdXcpdFm2PuMoe/JAYXqemDA1XQ/8YJi4tpOQ60cfBqKBlSkslWwR71Tj mAtWMkjnirzxLUEpq029oMM9IKGwJyB2IrcOEG1uKS6d/hhKO2YpWJEodt8GaAE2waDn 6OE8sWxHHRFCGGnUb+oqmJWnoLVal/cCy7FFPmcltPp0KSMjugNsForYEn7jGix7CGid R5RqZbQExayXgLtsGC4du5xty4pLPPzE/rMsKw0REhLHzpfddcZ+kaX1dh0OEHtFBXVN LGmNn/ZAPPQ4+VkqMOW+D/2g5v3It8l8LL8uV4+AWoJ/E3H0dcUmRWIf6DV6LGvzIOvc 2XTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZvFNfOtUNKQ7IKH3hFaEEj1f0tiENCiQ1lG+S/iP8QI=; b=E4V3oNW6mfdGFDgLPbMfG1Np9X+GkMc14cVCtqk/8pNppUzRttopiunh6sgT5bUBiB pFvR2R4kyQ2AL3RN39KY+/mEguh8kZVOZiEUhOgFmqWN5LWV29QHcF4Gdu/GaxVRodsD ChlLZUYkrvF1pRwSZe9VdCoRoBUmzZZr5/MRfHZs2JrJ5CqT7WNnx7DxtuolXjvArsGg ewp/uq9bAJqfcwNnL22Hj02wXLYekijLbcutWl5sWTb2WpRfybfmY/9A7+M0G8W339Uy +NamQm90sdqCC+7dBPMifwpGGYRjo4GewqhqQbgXwapSaf4uo5Js5cLxGtOB9PvVlJ3O L36w== X-Gm-Message-State: AOAM533SkkZWoH3XZNIy/zpvIa07TAoFTX+T0BgQpEadEIYKVLxE4zdE SDCmcuFKtHU5812UEJXEO+VoCbFn78U= X-Google-Smtp-Source: ABdhPJyDO9visWV84PWuxPCiFoe/6EosAaCtW1NCKYXg8E0tfGkiVhvcvZISRzPPJOremlNWTzmGNQ== X-Received: by 2002:a17:90b:3ec5:: with SMTP id rm5mr8612728pjb.132.1628660941709; Tue, 10 Aug 2021 22:49:01 -0700 (PDT) Received: from bobo.ibm.com ([118.210.97.79]) by smtp.gmail.com with ESMTPSA id q1sm1222317pjl.44.2021.08.10.22.49.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 22:49:01 -0700 (PDT) From: Nicholas Piggin To: skiboot@lists.ozlabs.org Date: Wed, 11 Aug 2021 15:48:47 +1000 Message-Id: <20210811054851.861482-3-npiggin@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210811054851.861482-1-npiggin@gmail.com> References: <20210811054851.861482-1-npiggin@gmail.com> MIME-Version: 1.0 Subject: [Skiboot] [PATCH v1 2/6] core/cpu: remove POWER8 IPI loop X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" POWER8 should not have to loop sending IPIs until the destination wakes up. One should be enough. Signed-off-by: Nicholas Piggin --- core/cpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/core/cpu.c b/core/cpu.c index 0dc013b5b..940b02ce4 100644 --- a/core/cpu.c +++ b/core/cpu.c @@ -599,10 +599,8 @@ static void reconfigure_idle_start(void) if (proc_gen == proc_gen_p8) { for_each_available_cpu(cpu) { - while (cpu->in_sleep || cpu->in_idle) { + if (cpu->in_sleep || cpu->in_idle) icp_kick_cpu(cpu); - cpu_relax(); - } } } else if (proc_gen == proc_gen_p9 || proc_gen == proc_gen_p10) { for_each_available_cpu(cpu) {