| Message ID | 20210405122303.282994-1-hegdevasant@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | opal-ci: Add openssl as dependency to fedora-rawhide | expand |
On Mon, 5 Apr 2021 17:53:03 +0530 Vasant Hegde <hegdevasant@linux.vnet.ibm.com> wrote: > openssl is needed by libstb. > > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > --- > opal-ci/Dockerfile-fedora-rawhide | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM, it is the "make check" target that needs openssl (the tool), right? Reviewed-by: Dan Horák <dan@danny.cz> Dan > > diff --git a/opal-ci/Dockerfile-fedora-rawhide b/opal-ci/Dockerfile-fedora-rawhide > index cc652fd46..0c9d23919 100644 > --- a/opal-ci/Dockerfile-fedora-rawhide > +++ b/opal-ci/Dockerfile-fedora-rawhide > @@ -1,5 +1,5 @@ > FROM fedora:rawhide > -RUN dnf -y install wget curl xterm gcc git xz make diffutils findutils expect valgrind valgrind-devel ccache dtc openssl-devel > +RUN dnf -y install wget curl xterm gcc git xz make diffutils findutils expect valgrind valgrind-devel ccache dtc openssl openssl-devel > RUN dnf -y install gcc-powerpc64-linux-gnu mbedtls-devel > # below packages are for building dtc > RUN dnf -y install flex bison > -- > 2.26.2 > > _______________________________________________ > Skiboot mailing list > Skiboot@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/skiboot
On 4/6/21 1:32 PM, Dan Horák wrote: > On Mon, 5 Apr 2021 17:53:03 +0530 > Vasant Hegde <hegdevasant@linux.vnet.ibm.com> wrote: > >> openssl is needed by libstb. >> >> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> >> --- >> opal-ci/Dockerfile-fedora-rawhide | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > LGTM, it is the "make check" target that needs openssl (the tool), > right? It gets failed while creating signed image. (libstb/sign-with-local-keys.sh need openssl) Sample log: --------------- [STB-DEVELOPMENT-SIGNED-CONTAINER] skiboot.lid.stb /build/libstb/sign-with-local-keys.sh: line 28: openssl: command not found /build/libstb/sign-with-local-keys.sh: line 29: openssl: command not found /build/libstb/sign-with-local-keys.sh: line 30: openssl: command not found /build/libstb/sign-with-local-keys.sh: line 33: openssl: command not found error: create-container.getSigRaw() line 152: Cannot mmap file [STB-DEVELOPMENT-SIGNED-CONTAINER] skiboot.lid.xz.stb /build/libstb/sign-with-local-keys.sh: line 28: openssl: command not found /build/libstb/sign-with-local-keys.sh: line 29: openssl: command not found /build/libstb/sign-with-local-keys.sh: line 30: openssl: command not found /build/libstb/sign-with-local-keys.sh: line 33: openssl: command not found error: create-container.getSigRaw() line 152: Cannot mmap file -Vasant > > Reviewed-by: Dan Horák <dan@danny.cz> > > > Dan > > >> >> diff --git a/opal-ci/Dockerfile-fedora-rawhide b/opal-ci/Dockerfile-fedora-rawhide >> index cc652fd46..0c9d23919 100644 >> --- a/opal-ci/Dockerfile-fedora-rawhide >> +++ b/opal-ci/Dockerfile-fedora-rawhide >> @@ -1,5 +1,5 @@ >> FROM fedora:rawhide >> -RUN dnf -y install wget curl xterm gcc git xz make diffutils findutils expect valgrind valgrind-devel ccache dtc openssl-devel >> +RUN dnf -y install wget curl xterm gcc git xz make diffutils findutils expect valgrind valgrind-devel ccache dtc openssl openssl-devel >> RUN dnf -y install gcc-powerpc64-linux-gnu mbedtls-devel >> # below packages are for building dtc >> RUN dnf -y install flex bison >> -- >> 2.26.2 >> >> _______________________________________________ >> Skiboot mailing list >> Skiboot@lists.ozlabs.org >> https://lists.ozlabs.org/listinfo/skiboot > _______________________________________________ > Skiboot mailing list > Skiboot@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/skiboot >
diff --git a/opal-ci/Dockerfile-fedora-rawhide b/opal-ci/Dockerfile-fedora-rawhide index cc652fd46..0c9d23919 100644 --- a/opal-ci/Dockerfile-fedora-rawhide +++ b/opal-ci/Dockerfile-fedora-rawhide @@ -1,5 +1,5 @@ FROM fedora:rawhide -RUN dnf -y install wget curl xterm gcc git xz make diffutils findutils expect valgrind valgrind-devel ccache dtc openssl-devel +RUN dnf -y install wget curl xterm gcc git xz make diffutils findutils expect valgrind valgrind-devel ccache dtc openssl openssl-devel RUN dnf -y install gcc-powerpc64-linux-gnu mbedtls-devel # below packages are for building dtc RUN dnf -y install flex bison
openssl is needed by libstb. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> --- opal-ci/Dockerfile-fedora-rawhide | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)