| Message ID | 20201218121038.752760-1-hegdevasant@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | SBE: Account cancelled timer request | expand |
On 12/18/20 5:40 PM, Vasant Hegde wrote: > Currently we are not accounting cancelled timer request. So in some > corner cases we may schedule new timer request with > new-timer-value > inflight-timer-value. > > Lets explicit check new_target value with inflight timer value. Merged to master as b44c75945. -Vasant
diff --git a/hw/sbe-p9.c b/hw/sbe-p9.c index f292d4df8..38e986757 100644 --- a/hw/sbe-p9.c +++ b/hw/sbe-p9.c @@ -814,6 +814,9 @@ static void p9_sbe_timer_schedule(void) u64 tb_cnt, now = mftb(); if (sbe_timer_in_progress) { + if (sbe_timer_target >= sbe_last_gen_stamp) + return; + if (now >= sbe_last_gen_stamp) return;
Currently we are not accounting cancelled timer request. So in some corner cases we may schedule new timer request with new-timer-value > inflight-timer-value. Lets explicit check new_target value with inflight timer value. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> --- hw/sbe-p9.c | 3 +++ 1 file changed, 3 insertions(+)