diff mbox series

[trivial] hdata: Replace hardcoded string with macro

Message ID 20201127132208.744847-1-hegdevasant@linux.vnet.ibm.com
State Accepted
Headers show
Series [trivial] hdata: Replace hardcoded string with macro | expand

Checks

Context Check Description
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco success Signed-off-by present
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot success Test snowpatch/job/snowpatch-skiboot on branch master
snowpatch_ozlabs/apply_patch success Successfully applied on branch master (b825589e085e23add8d0c58cfde7c8ed1f0b2dfd)

Commit Message

Vasant Hegde Nov. 27, 2020, 1:22 p.m. UTC
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
---
 hdata/tpmrel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dan Horák Nov. 30, 2020, 2:35 p.m. UTC | #1
On Fri, 27 Nov 2020 18:52:08 +0530
Vasant Hegde <hegdevasant@linux.vnet.ibm.com> wrote:

> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
> ---
>  hdata/tpmrel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM

Reviewed-by: Dan Horák <dan@danny.cz>


		Dan

> 
> diff --git a/hdata/tpmrel.c b/hdata/tpmrel.c
> index 8e36d3da3..4be3f81c4 100644
> --- a/hdata/tpmrel.c
> +++ b/hdata/tpmrel.c
> @@ -209,7 +209,7 @@ void node_stb_parse(void)
>  {
>  	struct HDIF_common_hdr *hdif_hdr;
>  
> -	hdif_hdr = get_hdif(&spira.ntuples.node_stb_data, "TPMREL");
> +	hdif_hdr = get_hdif(&spira.ntuples.node_stb_data, STB_HDIF_SIG);
>  	if (!hdif_hdr) {
>  		prlog(PR_DEBUG, "TPMREL data not found\n");
>  		return;
> -- 
> 2.26.2
> 
> _______________________________________________
> Skiboot mailing list
> Skiboot@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot
Vasant Hegde Dec. 16, 2020, 8 a.m. UTC | #2
On 11/27/20 6:52 PM, Vasant Hegde wrote:
> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
> ---

Merged to master as 0b34470e02a09.

-Vasant
diff mbox series

Patch

diff --git a/hdata/tpmrel.c b/hdata/tpmrel.c
index 8e36d3da3..4be3f81c4 100644
--- a/hdata/tpmrel.c
+++ b/hdata/tpmrel.c
@@ -209,7 +209,7 @@  void node_stb_parse(void)
 {
 	struct HDIF_common_hdr *hdif_hdr;
 
-	hdif_hdr = get_hdif(&spira.ntuples.node_stb_data, "TPMREL");
+	hdif_hdr = get_hdif(&spira.ntuples.node_stb_data, STB_HDIF_SIG);
 	if (!hdif_hdr) {
 		prlog(PR_DEBUG, "TPMREL data not found\n");
 		return;