Message ID | 20200616012324.12256-1-Nichole_Wang@wistron.com |
---|---|
State | Accepted |
Headers | show |
Series | [v2] platform/mihawk: Fix IPMI double-free | expand |
Context | Check | Description |
---|---|---|
snowpatch_ozlabs/apply_patch | success | Successfully applied on branch master (fe70fbb78d33abea788a3221bc409a7c50c019c3) |
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | success | Test snowpatch/job/snowpatch-skiboot on branch master |
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco | success | Signed-off-by present |
On 6/16/20 6:53 AM, Nichole Wang wrote: > From: nichole <Nichole_Wang@wistron.com> > > The commit 6826095 ("platform/mihawk: support dynamic PCIe slot table") > added the IPMI OEM command to communicate with BMC. We do the > ipmi_free_msg(msg) twice that caused the Fast-reboot fail. > > This patch fixes it by removing the IPMI double-free bug to restore > Fast-reboot. > > Signed-off-by: Nichole Wang <Nichole_Wang@wistron.com> > Cc: skiboot-stable@lists.ozlabs.org # skiboot-6.6.x > Cc: skiboot-stable@lists.ozlabs.org # skiboot-op940.x > Fixes: commit 6826095 ("platform/mihawk: support dynamic PCIe slot table") Looks good to me. Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> -Vasant
On Tue, Jun 16, 2020 at 11:24 AM Nichole Wang <Nichole_Wang@wistron.com> wrote: > > From: nichole <Nichole_Wang@wistron.com> > > The commit 6826095 ("platform/mihawk: support dynamic PCIe slot table") > added the IPMI OEM command to communicate with BMC. We do the > ipmi_free_msg(msg) twice that caused the Fast-reboot fail. > > This patch fixes it by removing the IPMI double-free bug to restore > Fast-reboot. > > Signed-off-by: Nichole Wang <Nichole_Wang@wistron.com> > Cc: skiboot-stable@lists.ozlabs.org # skiboot-6.6.x > Cc: skiboot-stable@lists.ozlabs.org # skiboot-op940.x > Fixes: commit 6826095 ("platform/mihawk: support dynamic PCIe slot table") Thanks, merged as 68dc040a6540c218d20517764ff5d740a3626c55
diff --git a/platforms/astbmc/mihawk.c b/platforms/astbmc/mihawk.c index f3669ff..54c2884 100644 --- a/platforms/astbmc/mihawk.c +++ b/platforms/astbmc/mihawk.c @@ -533,8 +533,6 @@ static void mihawk_init(void) if (timeout_ms == 0) break; } - - ipmi_free_msg(ipmi_msg); } prlog(PR_DEBUG, "Mihawk: IPMI_RISERF_QUERY finish. riser_state: %02x"