diff mbox series

uart: Actually swallow data if LPC is not working

Message ID 20200615060619.15170-1-hegdevasant@linux.vnet.ibm.com
State Accepted
Headers show
Series uart: Actually swallow data if LPC is not working | expand

Checks

Context Check Description
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco success Signed-off-by present
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot success Test snowpatch/job/snowpatch-skiboot on branch master
snowpatch_ozlabs/apply_patch success Successfully applied on branch master (fe70fbb78d33abea788a3221bc409a7c50c019c3)

Commit Message

Vasant Hegde June 15, 2020, 6:06 a.m. UTC
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
---
 hw/lpc-uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Oliver O'Halloran July 3, 2020, 5:39 a.m. UTC | #1
On Mon, Jun 15, 2020 at 4:06 PM Vasant Hegde
<hegdevasant@linux.vnet.ibm.com> wrote:
>
> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

That bug has only been there for... 5 years!

Thanks, merged as 53e4d7358c8f.
diff mbox series

Patch

diff --git a/hw/lpc-uart.c b/hw/lpc-uart.c
index 10c5ed4fe..a584eba91 100644
--- a/hw/lpc-uart.c
+++ b/hw/lpc-uart.c
@@ -189,7 +189,7 @@  static size_t uart_con_write(const char *buf, size_t len)
 
 	/* If LPC bus is bad, we just swallow data */
 	if (!lpc_ok() && !mmio_uart_base)
-		return written;
+		return len;
 
 	lock(&uart_lock);
 	while (written < len) {