| Message ID | 20200521192201.1855-2-grimm@linux.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Faster sim in XIVE path with undef BUDDY_DEBUG | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch master (0f1937ef40fca0c3212a9dff1010b832a24fb063) |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | success | Test snowpatch/job/snowpatch-skiboot on branch master |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco | success | Signed-off-by present |
On 5/21/20 9:22 PM, Ryan Grimm wrote: > In simulation, hundreds of millions of cycles are chewed up in this code > path: > > PC: 0x0000000030033450 -> <.bitmap_tst_bit>+0x18 > LR: 0x000000003003347c -> <.buddy_check_alloc>+0x14 > 0x0000000031c13b30 -> <_ebss>+0x1803b30 > 0x000000003003351c -> <.buddy_check_alloc_down>+0x4c > 0x00000000300339c4 -> <.buddy_free>+0x7c > 0x0000000030033be8 -> <.buddy_create>+0xcc > 0x0000000030089bbc -> <.xive_init>+0xf0 > 0x00000000300157cc -> <.main_cpu_entry>+0x8a0 > 0x000000003000275c -> <boot_entry>+0x1bc > > Undefining BUDDY_DEBUG saves 30+ minutes of wall clock time, so fix > the "warning: unused parameter" messages when compiling. Sure. The buddy allocator is only used by XIVE, may be we could simply use DEBUG. > Signed-off-by: Ryan Grimm <grimm@linux.ibm.com> Acked-by: Cédric Le Goater <clg@kaod.org> Thanks, C. > --- > core/buddy.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/core/buddy.c b/core/buddy.c > index 1f433dd6..b36e407d 100644 > --- a/core/buddy.c > +++ b/core/buddy.c > @@ -70,8 +70,8 @@ static void buddy_check_alloc_down(struct buddy *b, unsigned int node) > } > } > #else > -static inline void buddy_check_alloc(struct buddy *b, unsigned int node) {} > -static inline void buddy_check_alloc_down(struct buddy *b, unsigned int node) {} > +static inline void buddy_check_alloc(struct buddy *b __unused, unsigned int node __unused) {} > +static inline void buddy_check_alloc_down(struct buddy *b __unused, unsigned int node __unused) {} > #endif > > int buddy_alloc(struct buddy *b, unsigned int order) >
On Mon, May 25, 2020 at 5:35 PM Cédric Le Goater <clg@kaod.org> wrote: > > On 5/21/20 9:22 PM, Ryan Grimm wrote: > > In simulation, hundreds of millions of cycles are chewed up in this code > > path: > > > > PC: 0x0000000030033450 -> <.bitmap_tst_bit>+0x18 > > LR: 0x000000003003347c -> <.buddy_check_alloc>+0x14 > > 0x0000000031c13b30 -> <_ebss>+0x1803b30 > > 0x000000003003351c -> <.buddy_check_alloc_down>+0x4c > > 0x00000000300339c4 -> <.buddy_free>+0x7c > > 0x0000000030033be8 -> <.buddy_create>+0xcc > > 0x0000000030089bbc -> <.xive_init>+0xf0 > > 0x00000000300157cc -> <.main_cpu_entry>+0x8a0 > > 0x000000003000275c -> <boot_entry>+0x1bc > > > > Undefining BUDDY_DEBUG saves 30+ minutes of wall clock time, so fix > > the "warning: unused parameter" messages when compiling. > > Sure. The buddy allocator is only used by XIVE, may be we could simply > use DEBUG. > > > Signed-off-by: Ryan Grimm <grimm@linux.ibm.com> > > Acked-by: Cédric Le Goater <clg@kaod.org> Looks like I picked up the patch from patchwork before you Acked it so there's no ack in the merged patch. Sorry. Merged as fbc6c882727a5e16716f169b186d5e4d1da0b8b6
diff --git a/core/buddy.c b/core/buddy.c index 1f433dd6..b36e407d 100644 --- a/core/buddy.c +++ b/core/buddy.c @@ -70,8 +70,8 @@ static void buddy_check_alloc_down(struct buddy *b, unsigned int node) } } #else -static inline void buddy_check_alloc(struct buddy *b, unsigned int node) {} -static inline void buddy_check_alloc_down(struct buddy *b, unsigned int node) {} +static inline void buddy_check_alloc(struct buddy *b __unused, unsigned int node __unused) {} +static inline void buddy_check_alloc_down(struct buddy *b __unused, unsigned int node __unused) {} #endif int buddy_alloc(struct buddy *b, unsigned int order)
In simulation, hundreds of millions of cycles are chewed up in this code path: PC: 0x0000000030033450 -> <.bitmap_tst_bit>+0x18 LR: 0x000000003003347c -> <.buddy_check_alloc>+0x14 0x0000000031c13b30 -> <_ebss>+0x1803b30 0x000000003003351c -> <.buddy_check_alloc_down>+0x4c 0x00000000300339c4 -> <.buddy_free>+0x7c 0x0000000030033be8 -> <.buddy_create>+0xcc 0x0000000030089bbc -> <.xive_init>+0xf0 0x00000000300157cc -> <.main_cpu_entry>+0x8a0 0x000000003000275c -> <boot_entry>+0x1bc Undefining BUDDY_DEBUG saves 30+ minutes of wall clock time, so fix the "warning: unused parameter" messages when compiling. Signed-off-by: Ryan Grimm <grimm@linux.ibm.com> --- core/buddy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)