From patchwork Thu Mar 5 05:12:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver O'Halloran X-Patchwork-Id: 1249397 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48XzR015pyz9sPg for ; Thu, 5 Mar 2020 16:13:00 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=dLghh6sH; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48XzQz6wqdzDqlX for ; Thu, 5 Mar 2020 16:12:59 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::1041; helo=mail-pj1-x1041.google.com; envelope-from=oohall@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=dLghh6sH; dkim-atps=neutral Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48XzQs2f3HzDqlJ for ; Thu, 5 Mar 2020 16:12:53 +1100 (AEDT) Received: by mail-pj1-x1041.google.com with SMTP id a16so1979535pju.3 for ; Wed, 04 Mar 2020 21:12:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lqDU5jc9cET9m6pfnDlbc8ndAam2hrl5AYbByRrBL50=; b=dLghh6sHe421vJMPwhLXmkNBaS1Pifa+E0kgYBpx66tBaNcsd7inbj1MJqPoPYMIqE hDpQtuiWS3IwSuGBX/CGoP5/TPHe4UutF5Wg48gBDvGHN1o9HoSI2ZujoQOLTMT8lJSi /Kegrd0/ZguP7K/UJ/YHy688Yn06zNyhyCALZaYACvanAY2vIY4pXXVK35iAchass9PD j+cmKlCgpyHyqOWWop0o99uyF/FsALHVm4MH/zUF3/qOwknxOLBnoGrtoMmxmh+R9lbx D6kjwNZFyq5YdKh0jFaeyVQ2gs61YlpxucvBU5nmBRizF2S5RczMaKEfRbLdvsz3am4K WA8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lqDU5jc9cET9m6pfnDlbc8ndAam2hrl5AYbByRrBL50=; b=Uyji6vkjJDX2plYiGVPUMO4aR7MnWS7bs8IvhNoJP/OzVAtqW+CpBFlesYTKtgKP9O jF20KYzjQaoF5waek987zzyGE2vQVcHMAYr0NFk4BI9oHiHFnBmTV0glFt7fXFaLNXMl 24q6M6PfLaqRdjCN8HlUm6OC6sX0opSgyDpXcIyr/fGhZGpvy/6SthnJwu396vwKXJq6 p33FCKG1eDqWYJRsFhMErg2s5/gV3s1X+7noXP2sU3iZFRzLwZNqaeZlQtIfka1V6HPq i2yzCn2mYScTfuBEOgU5zTDTvQmCrAbBXdRh9b2MLRzaJN6isEX7antVcVod4ZgX83zb Ig5Q== X-Gm-Message-State: ANhLgQ1QBNJUs7G6OL5srgfbx7gMN8ydOBmFqVcFBmOH/Sihc8go8xvC 5SCz3TduQKeGfPgC3Uvdsnlb+6I6wyQ= X-Google-Smtp-Source: ADFU+vvuEU94ESQc1M9HoMe7pl/ETz3crKJlAhdhIkni1aBwXmmnbSWp4xF3ANtnFd8/9KKW8HYvnQ== X-Received: by 2002:a17:902:bf08:: with SMTP id bi8mr6355962plb.305.1583385169589; Wed, 04 Mar 2020 21:12:49 -0800 (PST) Received: from wafer.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id i131sm9920566pgc.18.2020.03.04.21.12.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 21:12:48 -0800 (PST) From: Oliver O'Halloran To: skiboot@lists.ozlabs.org Date: Thu, 5 Mar 2020 16:12:38 +1100 Message-Id: <20200305051238.4621-1-oohall@gmail.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Subject: [Skiboot] [PATCH] hw/fsp: Remove stray va_end() in __fsp_fillmsg() X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" __fsp_fillmsg() is called from fsp_fillmsg() and fsp_mkmsg(). Both callers wrap it in a va_start() / va_end() pair so using va_end() inside the function is almost certainly wrong. Signed-off-by: Oliver O'Halloran --- circa 2012 ben code, might be the oldest bug in skiboot. --- --- hw/fsp/fsp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/fsp/fsp.c b/hw/fsp/fsp.c index 196fa34d5dbf..392cf5d36409 100644 --- a/hw/fsp/fsp.c +++ b/hw/fsp/fsp.c @@ -995,7 +995,6 @@ static void __fsp_fillmsg(struct fsp_msg *msg, u32 cmd_sub_mod, for (i = 0; i < add_words; i++) fsp_msg_set_data_word(msg, i, va_arg(list, unsigned int)); - va_end(list); } void fsp_fillmsg(struct fsp_msg *msg, u32 cmd_sub_mod, u32 add_words, ...)