| Message ID | 20200205171545.26796-1-hegdevasant@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | mpipl: Disable fast-reboot during post MPIPL boot | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch master (179d53dfcca30436777b0c748d530a979bbc8a45) |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | success | Test snowpatch/job/snowpatch-skiboot on branch master |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco | success | Signed-off-by present |
> On 5 Feb 2020, at 09:16, Vasant Hegde <hegdevasant@linux.vnet.ibm.com> wrote: > > Otherwise device tree will continue to have `mpipl-boot` and kernel may > think its MPIPL boot. > > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > --- > core/opal-dump.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/core/opal-dump.c b/core/opal-dump.c > index 9b71c6468..4d7527f67 100644 > --- a/core/opal-dump.c > +++ b/core/opal-dump.c > @@ -532,6 +532,8 @@ void opal_mpipl_init(void) > mpipl_metadata = (void *)(DUMP_METADATA_AREA_BASE); > > if (dt_find_property(dump_node, "mpipl-boot")) { > + disable_fast_reboot("MPIPL Boot"); > + > post_mpipl_get_preserved_tags(); > post_mpipl_get_opal_data(); > post_mpipl_arch_regs_data(); Yeah, makes a lot of sense Reviewed-by: Stewart Smith <stewart@flamingspork.com> > -- > 2.21.1 > > _______________________________________________ > Skiboot mailing list > Skiboot@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/skiboot
On Thu, Feb 6, 2020 at 4:15 AM Vasant Hegde <hegdevasant@linux.vnet.ibm.com> wrote: > > Otherwise device tree will continue to have `mpipl-boot` and kernel may > think its MPIPL boot. > > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Thanks, merged as b858aef5210e98b19419ad4dc347cf96d89cbf85
diff --git a/core/opal-dump.c b/core/opal-dump.c index 9b71c6468..4d7527f67 100644 --- a/core/opal-dump.c +++ b/core/opal-dump.c @@ -532,6 +532,8 @@ void opal_mpipl_init(void) mpipl_metadata = (void *)(DUMP_METADATA_AREA_BASE); if (dt_find_property(dump_node, "mpipl-boot")) { + disable_fast_reboot("MPIPL Boot"); + post_mpipl_get_preserved_tags(); post_mpipl_get_opal_data(); post_mpipl_arch_regs_data();
Otherwise device tree will continue to have `mpipl-boot` and kernel may think its MPIPL boot. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> --- core/opal-dump.c | 2 ++ 1 file changed, 2 insertions(+)