| Message ID | 20200128155548.5509-1-hegdevasant@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hdata: Update MPIPL support IPL parameter | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch master (120b1b7d764e5ebad8136b695f38a710eea897df) |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | success | Test snowpatch/job/snowpatch-skiboot on branch master |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco | success | Signed-off-by present |
On Wed, Jan 29, 2020 at 2:55 AM Vasant Hegde <hegdevasant@linux.vnet.ibm.com> wrote: > > We used bit 4 of `sys_attributes` attribute for MPIPL supported flag. > Unfortunately we forgot to update HDAT spec. Now bit 4 is used for > different purpose. Hence use bit 5 for MPIPL. ... What is bit 4 and can any currently released firmware set it? If it can then we should backport this to stable. > Fortunately we don't have any released firmware with MPIPL supported yet. > Hence its safe to make this change. > > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > --- > hdata/spira.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hdata/spira.h b/hdata/spira.h > index 2c2872260..8744d0a59 100644 > --- a/hdata/spira.h > +++ b/hdata/spira.h > @@ -352,7 +352,7 @@ struct iplparams_sysparams { > __be32 sys_eco_mode; > #define SYS_ATTR_MULTIPLE_TPM PPC_BIT32(0) > #define SYS_ATTR_RISK_LEVEL PPC_BIT32(3) > -#define SYS_ATTR_MPIPL_SUPPORTED PPC_BIT32(4) > +#define SYS_ATTR_MPIPL_SUPPORTED PPC_BIT32(5) > __be32 sys_attributes; > __be32 mem_scrubbing; > __be16 cur_spl_value; > -- > 2.21.0 >
On 1/29/20 6:34 AM, Oliver O'Halloran wrote: > On Wed, Jan 29, 2020 at 2:55 AM Vasant Hegde > <hegdevasant@linux.vnet.ibm.com> wrote: >> >> We used bit 4 of `sys_attributes` attribute for MPIPL supported flag. >> Unfortunately we forgot to update HDAT spec. Now bit 4 is used for >> different purpose. Hence use bit 5 for MPIPL. > > ... > > What is bit 4 and can any currently released firmware set it? If it > can then we should backport this to stable. Bit 4 is for USB disable. AFAIK none of the released firmware has that. Agree. May be we should backport this fix for v6.5.x stable branch as well. -Vasant > >> Fortunately we don't have any released firmware with MPIPL supported yet. >> Hence its safe to make this change. >> >> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> >> --- >> hdata/spira.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hdata/spira.h b/hdata/spira.h >> index 2c2872260..8744d0a59 100644 >> --- a/hdata/spira.h >> +++ b/hdata/spira.h >> @@ -352,7 +352,7 @@ struct iplparams_sysparams { >> __be32 sys_eco_mode; >> #define SYS_ATTR_MULTIPLE_TPM PPC_BIT32(0) >> #define SYS_ATTR_RISK_LEVEL PPC_BIT32(3) >> -#define SYS_ATTR_MPIPL_SUPPORTED PPC_BIT32(4) >> +#define SYS_ATTR_MPIPL_SUPPORTED PPC_BIT32(5) >> __be32 sys_attributes; >> __be32 mem_scrubbing; >> __be16 cur_spl_value; >> -- >> 2.21.0 >>
On Wed, Jan 29, 2020 at 2:55 AM Vasant Hegde <hegdevasant@linux.vnet.ibm.com> wrote: > > We used bit 4 of `sys_attributes` attribute for MPIPL supported flag. > Unfortunately we forgot to update HDAT spec. Now bit 4 is used for > different purpose. Hence use bit 5 for MPIPL. > > Fortunately we don't have any released firmware with MPIPL supported yet. > Hence its safe to make this change. > > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > --- Merged as a448c4e2f6c3962b1690e367d1a2a8e03180b320
diff --git a/hdata/spira.h b/hdata/spira.h index 2c2872260..8744d0a59 100644 --- a/hdata/spira.h +++ b/hdata/spira.h @@ -352,7 +352,7 @@ struct iplparams_sysparams { __be32 sys_eco_mode; #define SYS_ATTR_MULTIPLE_TPM PPC_BIT32(0) #define SYS_ATTR_RISK_LEVEL PPC_BIT32(3) -#define SYS_ATTR_MPIPL_SUPPORTED PPC_BIT32(4) +#define SYS_ATTR_MPIPL_SUPPORTED PPC_BIT32(5) __be32 sys_attributes; __be32 mem_scrubbing; __be16 cur_spl_value;
We used bit 4 of `sys_attributes` attribute for MPIPL supported flag. Unfortunately we forgot to update HDAT spec. Now bit 4 is used for different purpose. Hence use bit 5 for MPIPL. Fortunately we don't have any released firmware with MPIPL supported yet. Hence its safe to make this change. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> --- hdata/spira.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)