diff mbox series

[v2,1/2] makefiles: Make attribute suggestions non-errors

Message ID 20191113121422.20503-1-oohall@gmail.com
State Accepted
Headers show
Series [v2,1/2] makefiles: Make attribute suggestions non-errors | expand


Context Check Description
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco success Signed-off-by present
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot success Test snowpatch/job/snowpatch-skiboot on branch master
snowpatch_ozlabs/apply_patch success Successfully applied on branch master (d75e82dbfbb9443efeb3f9a5921ac23605aab469)

Commit Message

Oliver O'Halloran Nov. 13, 2019, 12:14 p.m. UTC
Different versions of GCC don't have different ideas about when the
suggestion should be made. That, combined with -Werror being enabled
results in spurious compilation failures for dumb reasons. They're
also really annoying when tinkering.

They do however make good suggestions on occasion so leave them enabled
with -Wno-error enabled so they don't cause compile failures.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
 Makefile.main | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
diff mbox series


diff --git a/Makefile.main b/Makefile.main
index 2d60bbbf5e41..4d7ebcec98d7 100644
--- a/Makefile.main
+++ b/Makefile.main
@@ -42,7 +42,9 @@  HOSTCFLAGS += $(call try-cflag,$(HOSTCC),-std=gnu11)
 HOSTCFLAGS += $(call try-cflag,$(HOSTCC),-m64)
 HOSTCFLAGS += $(call try-cflag,$(HOSTCC),-Wjump-misses-init) \
 	  $(call try-cflag,$(HOSTCC),-Wsuggest-attribute=const) \
-	  $(call try-cflag,$(HOSTCC),-Wsuggest-attribute=noreturn)
+	  $(call try-cflag,$(HOSTCC),-Wsuggest-attribute=noreturn) \
+	  $(call try-cflag,$(HOSTCC),-Wno-error=suggest-attribute=const) \
+	  $(call try-cflag,$(HOSTCC),-Wno-error=suggest-attribute=noreturn)
 # We want small stack usage for skiboot
@@ -126,6 +128,8 @@  endif
 CFLAGS += $(call try-cflag,$(CC),-Wjump-misses-init) \
 	  $(call try-cflag,$(CC),-Wsuggest-attribute=const) \
 	  $(call try-cflag,$(CC),-Wsuggest-attribute=noreturn) \
+	  $(call try-cflag,$(CC),-Wno-error=suggest-attribute=const) \
+	  $(call try-cflag,$(CC),-Wno-error=suggest-attribute=noreturn) \
 	  $(call try-cflag,$(CC),-Wstack-usage=1024) \
 	  $(call try-cflag,$(CC),-Wno-error=address-of-packed-member)