diff mbox series

prd: Improve debug logs

Message ID 20191022112643.16099-1-hegdevasant@linux.vnet.ibm.com
State Accepted
Headers show
Series prd: Improve debug logs | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success Successfully applied on branch master (d75e82dbfbb9443efeb3f9a5921ac23605aab469)
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot success Test snowpatch/job/snowpatch-skiboot on branch master
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco success Signed-off-by present

Commit Message

Vasant Hegde Oct. 22, 2019, 11:26 a.m. UTC
.. helps in debugging.

Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
---
 hw/prd.c                         | 3 ++-
 platforms/ibm-fsp/hostservices.c | 4 +++-
 2 files changed, 5 insertions(+), 2 deletions(-)

Comments

Oliver O'Halloran Nov. 8, 2019, 5:08 a.m. UTC | #1
On Tue, Oct 22, 2019 at 10:26 PM Vasant Hegde
<hegdevasant@linux.vnet.ibm.com> wrote:
>
> .. helps in debugging.
>
> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

Merged as f15577959fc68652c910c4c5aa09876babc5f993
diff mbox series

Patch

diff --git a/hw/prd.c b/hw/prd.c
index db25985b8..d9198f0eb 100644
--- a/hw/prd.c
+++ b/hw/prd.c
@@ -370,7 +370,8 @@  int prd_hbrt_fsp_msg_notify(void *data, u32 dsize)
 	enum opal_msg_type msg_type = OPAL_MSG_PRD2;
 
 	if (!prd_enabled || !prd_active) {
-		prlog(PR_NOTICE, "PRD: PRD daemon is not ready\n");
+		prlog(PR_NOTICE, "PRD: %s: PRD daemon is not ready\n",
+		      __func__);
 		return rc;
 	}
 
diff --git a/platforms/ibm-fsp/hostservices.c b/platforms/ibm-fsp/hostservices.c
index 3bdad4a5e..1c199af11 100644
--- a/platforms/ibm-fsp/hostservices.c
+++ b/platforms/ibm-fsp/hostservices.c
@@ -882,8 +882,10 @@  static bool hservice_hbrt_msg_notify(uint32_t cmd_sub_mod, struct fsp_msg *msg)
 		return true;
 	}
 
-	if (prd_hbrt_fsp_msg_notify(buf, len))
+	if (prd_hbrt_fsp_msg_notify(buf, len)) {
 		hservice_hbrt_msg_response(FSP_STATUS_GENERIC_FAILURE);
+		prlog(PR_NOTICE, "Unable to send FSP - HBRT message\n");
+	}
 
 	return true;
 }