diff mbox series

[v4,03/15] capp: fix endian conversion

Message ID 20191009234951.2850-4-npiggin@gmail.com
State Superseded
Headers show
Series little endian skiboot | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success Successfully applied on branch master (1785745d5a7eaefd7d0c135f2a3b0f5d86aefec5)
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot success Test snowpatch/job/snowpatch-skiboot on branch master
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco success Signed-off-by present

Commit Message

Nicholas Piggin Oct. 9, 2019, 11:49 p.m. UTC 
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 hw/capp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stewart Smith Oct. 10, 2019, 3:10 p.m. UTC | #1 
On Wed, Oct 9, 2019, at 4:49 PM, Nicholas Piggin wrote:
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
>  hw/capp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/capp.c b/hw/capp.c
> index 709e6db14..269deb637 100644
> --- a/hw/capp.c
> +++ b/hw/capp.c
> @@ -168,7 +168,7 @@ int64_t capp_load_ucode(unsigned int chip_id, 
> uint32_t opal_id,
>  
>  	/* 'CAPPULID' in ASCII */
>  	if ((be64_to_cpu(ucode->eyecatcher) != 0x43415050554C4944UL) ||
> -	    (be64_to_cpu(ucode->version != 1))) {
> +	    (be64_to_cpu(ucode->version) != 1)) {
>  		PHBERR(opal_id, chip_id, index,
>  		       "CAPP: ucode header invalid\n");
>  		return OPAL_HARDWARE;

I'm sure the git-blame firmly blames me in some way for that. Whoops.

Acked-by: Stewart Smith <stewart@flamingspork.com>
Andrew Donnellan Oct. 10, 2019, 9:33 p.m. UTC | #2 
Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>

as per last time

On 10/10/19 10:49 am, Nicholas Piggin wrote:
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
>   hw/capp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/capp.c b/hw/capp.c
> index 709e6db14..269deb637 100644
> --- a/hw/capp.c
> +++ b/hw/capp.c
> @@ -168,7 +168,7 @@ int64_t capp_load_ucode(unsigned int chip_id, uint32_t opal_id,
>   
>   	/* 'CAPPULID' in ASCII */
>   	if ((be64_to_cpu(ucode->eyecatcher) != 0x43415050554C4944UL) ||
> -	    (be64_to_cpu(ucode->version != 1))) {
> +	    (be64_to_cpu(ucode->version) != 1)) {
>   		PHBERR(opal_id, chip_id, index,
>   		       "CAPP: ucode header invalid\n");
>   		return OPAL_HARDWARE;
>
Nicholas Piggin Oct. 12, 2019, 10:22 p.m. UTC | #3 
Andrew Donnellan's on October 11, 2019 7:33 am:
> Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
> 
> as per last time

Sorry forgot to pick up your R-B.

Thanks,
Nick
diff mbox series

Patch

diff --git a/hw/capp.c b/hw/capp.c
index 709e6db14..269deb637 100644
--- a/hw/capp.c
+++ b/hw/capp.c
@@ -168,7 +168,7 @@  int64_t capp_load_ucode(unsigned int chip_id, uint32_t opal_id,
 
 	/* 'CAPPULID' in ASCII */
 	if ((be64_to_cpu(ucode->eyecatcher) != 0x43415050554C4944UL) ||
-	    (be64_to_cpu(ucode->version != 1))) {
+	    (be64_to_cpu(ucode->version) != 1)) {
 		PHBERR(opal_id, chip_id, index,
 		       "CAPP: ucode header invalid\n");
 		return OPAL_HARDWARE;