From patchwork Fri Oct 4 04:02:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1171552 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46kx8f0yd5z9sPv for ; Fri, 4 Oct 2019 14:04:34 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="o7afyPfK"; dkim-atps=neutral Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46kx8d0JppzDqbk for ; Fri, 4 Oct 2019 14:04:33 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::442; helo=mail-pf1-x442.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="o7afyPfK"; dkim-atps=neutral Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46kx7j3GNKzDqbg for ; Fri, 4 Oct 2019 14:03:45 +1000 (AEST) Received: by mail-pf1-x442.google.com with SMTP id b128so3086992pfa.1 for ; Thu, 03 Oct 2019 21:03:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D898OVmCpaXB7gf0K4GVYHo3J3bIM1vKrcipi1vF/Dk=; b=o7afyPfKnI9dtPxat06LpnQyMhfDftDfd3U+VWRM/TyjW4QINRXD7NfUotjhEMD1Ae Ic8vKPRUYl+fEiRokqgBb2zAqzJOOyiF5qaDoTKwi47RG98v1deuJuebhHvZLBtO1RAi B91BA8sZwa1fQFDqEaBFTDtig9WIQ6lFFku+jWa23ViKTOV4Xv/XDe2RQx/XpWfUidk4 Q8mKXwbU9oNtEniMnaNaYPPsMbSsyNT9MVvMFLcZ1bX/Hcpi5gJrsiKD8oIfGHxAsNvw jUAcmcn7dQ+ARW19mOYI047RQ2XRabVG9lmwH8bsf52Yti6NeJRHnJYy9/UdXWxuFjq2 Jnfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D898OVmCpaXB7gf0K4GVYHo3J3bIM1vKrcipi1vF/Dk=; b=g6C4+iR6/JUmeHT3rpHsOAJYFXAacN2hGlp55y7rsk18e30h7eDZvVjOVzrApcyUTU f4xujisAp8i74+XlS1KLKEOj2dST+gbFLSD5f0Pc1D87SE2KIDTsv3ET7WuSF2HyzEBU w3ADMjwzN1bchMdP8xSd6ifu3dX9/6A51rIsZQsXW2Lr2dIVisJZOQhocYMZT/QJfXh0 VYuIsvfBokyeoBp89mv1hTU33WDcqQgwgTxqxK2XdaqBRam8R41AcgmrZI1l+j3ZFHY0 EcjBwMvw0tTsZveSwWfnVyqyd+NGjA9NlLNCygjJ6dzt42o4yeC4g2YxWzpnYmV/+jWa M45A== X-Gm-Message-State: APjAAAVw2gHmhjg2JYwcfCs9MskHoc9hKtVoQRJS3i8xsuOrpGb3KAzT 7W9mChJ/GeeK9Vsc9PKseBjudced X-Google-Smtp-Source: APXvYqyD/biV+FOl3wSCWjFi/QKVo+sLV7XJob9eWUoepzrl77QY1ctpqZCuirlrUDI/LpDvrrBn4A== X-Received: by 2002:a63:5946:: with SMTP id j6mr13158218pgm.66.1570161822528; Thu, 03 Oct 2019 21:03:42 -0700 (PDT) Received: from bobo.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id z29sm3939291pff.23.2019.10.03.21.03.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2019 21:03:41 -0700 (PDT) From: Nicholas Piggin To: skiboot@lists.ozlabs.org Date: Fri, 4 Oct 2019 14:02:15 +1000 Message-Id: <20191004040227.22186-3-npiggin@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191004040227.22186-1-npiggin@gmail.com> References: <20191004040227.22186-1-npiggin@gmail.com> MIME-Version: 1.0 Subject: [Skiboot] [PATCH v3 02/14] capp: fix endian conversion X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Signed-off-by: Nicholas Piggin Reviewed-by: Andrew Donnellan --- hw/capp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/capp.c b/hw/capp.c index 709e6db14..269deb637 100644 --- a/hw/capp.c +++ b/hw/capp.c @@ -168,7 +168,7 @@ int64_t capp_load_ucode(unsigned int chip_id, uint32_t opal_id, /* 'CAPPULID' in ASCII */ if ((be64_to_cpu(ucode->eyecatcher) != 0x43415050554C4944UL) || - (be64_to_cpu(ucode->version != 1))) { + (be64_to_cpu(ucode->version) != 1)) { PHBERR(opal_id, chip_id, index, "CAPP: ucode header invalid\n"); return OPAL_HARDWARE;