From patchwork Thu Jul 18 06:51:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 1133556 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45q4bT3z1Zz9s8m for ; Thu, 18 Jul 2019 16:53:25 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45q4bT2LbHzDqZD for ; Thu, 18 Jul 2019 16:53:25 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=stewart@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45q4YD09V0zDqLL for ; Thu, 18 Jul 2019 16:51:27 +1000 (AEST) Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6I6mY8m045157 for ; Thu, 18 Jul 2019 02:51:25 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ttjrbjwf6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 02:51:25 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x6I6isD9031596 for ; Thu, 18 Jul 2019 06:51:24 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma04dal.us.ibm.com with ESMTP id 2trtmrdvmf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 06:51:24 +0000 Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6I6pNjj61538632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Jul 2019 06:51:23 GMT Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EBC16136055 for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B3C9C136059 for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: from birb.localdomain (unknown [9.185.142.34]) by b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP for ; Thu, 18 Jul 2019 06:51:22 +0000 (GMT) Received: by birb.localdomain (Postfix, from userid 1000) id 87761476572; Thu, 18 Jul 2019 16:51:18 +1000 (AEST) From: Stewart Smith To: skiboot@lists.ozlabs.org Date: Thu, 18 Jul 2019 16:51:16 +1000 Message-Id: <20190718065117.16923-10-stewart@linux.ibm.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190718065117.16923-1-stewart@linux.ibm.com> References: <20190718065117.16923-1-stewart@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-18_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907180077 Subject: [Skiboot] [PATCH 09/10] sparse: hdata/spira sw_xstop_fir_bitpos is uint8_t, has no endian X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" hdata/spira.c:625:33: warning: incorrect type in argument 1 (different base types) hdata/spira.c:625:33: expected restricted beint32_t [usertype] be_val hdata/spira.c:625:33: got unsigned char [usertype] fir_bit hdata/spira.c:625:33: warning: incorrect type in argument 1 (different base types) hdata/spira.c:625:33: expected restricted beint32_t [usertype] be_val hdata/spira.c:625:33: got unsigned char [usertype] fir_bit Signed-off-by: Stewart Smith --- hdata/spira.c | 4 ++-- hdata/test/op920.wsp.dts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hdata/spira.c b/hdata/spira.c index 945cc7e8c50f..dad779fa223d 100644 --- a/hdata/spira.c +++ b/hdata/spira.c @@ -619,13 +619,13 @@ static bool add_xscom_sppcrd(uint64_t xscom_base) if ((csize >= (offsetof(struct sppcrd_chip_info, sw_xstop_fir_bitpos) + 1)) && cinfo->sw_xstop_fir_scom) { - __be32 fir_bit = cinfo->sw_xstop_fir_bitpos; + uint8_t fir_bit = cinfo->sw_xstop_fir_bitpos; if (!dt_find_property(dt_root, "ibm,sw-checkstop-fir")) dt_add_property_cells(dt_root, "ibm,sw-checkstop-fir", be32_to_cpu(cinfo->sw_xstop_fir_scom), - be32_to_cpu(fir_bit)); + fir_bit); } } diff --git a/hdata/test/op920.wsp.dts b/hdata/test/op920.wsp.dts index fbc5a39c8a53..b9aa0f204b3c 100644 --- a/hdata/test/op920.wsp.dts +++ b/hdata/test/op920.wsp.dts @@ -8,7 +8,7 @@ ibm,io-base-loc-code = "UOPWR.7887E6A-Node0"; nest-frequency = <0x0 0x77359400>; vendor = "IBM"; - ibm,sw-checkstop-fir = <0x5012000 0x1f000000>; + ibm,sw-checkstop-fir = <0x5012000 0x1f>; model = "8335-GTH"; system-id = "7887E6A"; model-name = "ibm,witherspoon";