From patchwork Tue Jul 9 15:05:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Barrat X-Patchwork-Id: 1129877 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45jlyX6yTwz9s8m for ; Wed, 10 Jul 2019 01:06:28 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45jlyX62jFzDqY6 for ; Wed, 10 Jul 2019 01:06:28 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=fbarrat@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45jlyB0XH5zDqT2 for ; Wed, 10 Jul 2019 01:06:09 +1000 (AEST) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x69EwDj8115496 for ; Tue, 9 Jul 2019 11:06:07 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2tmtvq7339-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 09 Jul 2019 11:06:05 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 9 Jul 2019 16:06:02 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 9 Jul 2019 16:06:00 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x69F5xVq38994098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 9 Jul 2019 15:05:59 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1C2B911C052; Tue, 9 Jul 2019 15:05:59 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CA67711C04A; Tue, 9 Jul 2019 15:05:58 +0000 (GMT) Received: from pic2.home (unknown [9.145.69.11]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 9 Jul 2019 15:05:58 +0000 (GMT) From: Frederic Barrat To: skiboot@lists.ozlabs.org, andrew.donnellan@au1.ibm.com, clombard@linux.ibm.com Date: Tue, 9 Jul 2019 17:05:57 +0200 X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 19070915-0012-0000-0000-00000330B1F6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19070915-0013-0000-0000-0000216A17AB Message-Id: <20190709150558.14957-1-fbarrat@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-09_06:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=834 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907090179 Subject: [Skiboot] [PATCH v2 1/2] hdata: Align SMP link definitions with current HDAT spec X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hegdevasant@linux.ibm.com Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" All link usage values other than GPU were unused, so there's no functional change or backward compatibility issue. Signed-off-by: Frederic Barrat --- Changelog: v2: new patch for minor cleanup hdata/spira.c | 2 +- hdata/spira.h | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/hdata/spira.c b/hdata/spira.c index 6891a9c7..3d7e21cd 100644 --- a/hdata/spira.c +++ b/hdata/spira.c @@ -1370,7 +1370,7 @@ static void add_npu(struct dt_node *xscom, const struct HDIF_array_hdr *links, struct dt_node *node; /* only add a link node if this link is targeted at at device */ - if (be32_to_cpu(link->usage) != SMP_LINK_USE_DEVICE) + if (be32_to_cpu(link->usage) != SMP_LINK_USE_GPU) continue; /* diff --git a/hdata/spira.h b/hdata/spira.h index 09de4dad..563a98c2 100644 --- a/hdata/spira.h +++ b/hdata/spira.h @@ -1175,10 +1175,11 @@ struct sppcrd_smp_link { __be32 link_id; __be32 usage; #define SMP_LINK_USE_NONE 0 -#define SMP_LINK_USE_DEVICE 1 -#define SMP_LINK_USE_INTERPOSER 2 -#define SMP_LINK_USE_DRAWER 3 -#define SMP_LINK_USE_D2D 4 /* GPU to GPU */ +#define SMP_LINK_USE_GPU 1 +#define SMP_LINK_USE_OPENCAPI 2 +#define SMP_LINK_USE_INTERPOSER 3 +#define SMP_LINK_USE_DRAWER 4 +#define SMP_LINK_USE_D2D 5 /* GPU to GPU */ __be32 brick_id; __be32 lane_mask;