| Message ID | 20190624084229.21619-1-hegdevasant@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | platform/zz: Add new platform type | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch master (b904cb733750de1bb0e04e5012c391a9c3094d11) |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | fail | Test snowpatch/job/snowpatch-skiboot on branch master |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco | success | Signed-off-by present |
On Mon, Jun 24, 2019 at 6:43 PM Vasant Hegde <hegdevasant@linux.vnet.ibm.com> wrote: > > We have new platform type under ZZ. Lets add them. With this fix > we are able to boot the system. > > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > --- > platforms/ibm-fsp/zz.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/platforms/ibm-fsp/zz.c b/platforms/ibm-fsp/zz.c > index 705906a04..96259c35b 100644 > --- a/platforms/ibm-fsp/zz.c > +++ b/platforms/ibm-fsp/zz.c > @@ -51,7 +51,10 @@ static bool zz_probe(void) > if (dt_node_is_compatible(dt_root, "ibm,zz-1s2u") || > dt_node_is_compatible(dt_root, "ibm,zz-1s4u") || > dt_node_is_compatible(dt_root, "ibm,zz-2s2u") || > - dt_node_is_compatible(dt_root, "ibm,zz-2s4u")) > + dt_node_is_compatible(dt_root, "ibm,zz-2s4u") || > + dt_node_is_compatible(dt_root, "ibm,zz-1s4u+gen4") || > + dt_node_is_compatible(dt_root, "ibm,zz-2s2u+gen4") || > + dt_node_is_compatible(dt_root, "ibm,zz-2s4u+gen4")) > return true; I'm starting to think we might be better off just using strncmp() and looking at the "ibm,zz" prefix. Oh well. > return false; > -- > 2.14.3 > > _______________________________________________ > Skiboot mailing list > Skiboot@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/skiboot
"Oliver O'Halloran" <oohall@gmail.com> writes: > On Mon, Jun 24, 2019 at 6:43 PM Vasant Hegde > <hegdevasant@linux.vnet.ibm.com> wrote: >> >> We have new platform type under ZZ. Lets add them. With this fix >> we are able to boot the system. >> >> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> >> --- >> platforms/ibm-fsp/zz.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/platforms/ibm-fsp/zz.c b/platforms/ibm-fsp/zz.c >> index 705906a04..96259c35b 100644 >> --- a/platforms/ibm-fsp/zz.c >> +++ b/platforms/ibm-fsp/zz.c >> @@ -51,7 +51,10 @@ static bool zz_probe(void) >> if (dt_node_is_compatible(dt_root, "ibm,zz-1s2u") || >> dt_node_is_compatible(dt_root, "ibm,zz-1s4u") || >> dt_node_is_compatible(dt_root, "ibm,zz-2s2u") || >> - dt_node_is_compatible(dt_root, "ibm,zz-2s4u")) >> + dt_node_is_compatible(dt_root, "ibm,zz-2s4u") || >> + dt_node_is_compatible(dt_root, "ibm,zz-1s4u+gen4") || >> + dt_node_is_compatible(dt_root, "ibm,zz-2s2u+gen4") || >> + dt_node_is_compatible(dt_root, "ibm,zz-2s4u+gen4")) >> return true; > > I'm starting to think we might be better off just using strncmp() and > looking at the "ibm,zz" prefix. Oh well. Although, failing to boot *does* end up letting us know that new machines exist. Otherwise people don't tell us, and will probably just ship them.
On Tue, Jun 25, 2019 at 1:25 PM Stewart Smith <stewart@linux.ibm.com> wrote: > > "Oliver O'Halloran" <oohall@gmail.com> writes: > > On Mon, Jun 24, 2019 at 6:43 PM Vasant Hegde > > <hegdevasant@linux.vnet.ibm.com> wrote: > >> > >> We have new platform type under ZZ. Lets add them. With this fix > >> we are able to boot the system. > >> > >> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > >> --- > >> platforms/ibm-fsp/zz.c | 5 ++++- > >> 1 file changed, 4 insertions(+), 1 deletion(-) > >> > >> diff --git a/platforms/ibm-fsp/zz.c b/platforms/ibm-fsp/zz.c > >> index 705906a04..96259c35b 100644 > >> --- a/platforms/ibm-fsp/zz.c > >> +++ b/platforms/ibm-fsp/zz.c > >> @@ -51,7 +51,10 @@ static bool zz_probe(void) > >> if (dt_node_is_compatible(dt_root, "ibm,zz-1s2u") || > >> dt_node_is_compatible(dt_root, "ibm,zz-1s4u") || > >> dt_node_is_compatible(dt_root, "ibm,zz-2s2u") || > >> - dt_node_is_compatible(dt_root, "ibm,zz-2s4u")) > >> + dt_node_is_compatible(dt_root, "ibm,zz-2s4u") || > >> + dt_node_is_compatible(dt_root, "ibm,zz-1s4u+gen4") || > >> + dt_node_is_compatible(dt_root, "ibm,zz-2s2u+gen4") || > >> + dt_node_is_compatible(dt_root, "ibm,zz-2s4u+gen4")) > >> return true; > > > > I'm starting to think we might be better off just using strncmp() and > > looking at the "ibm,zz" prefix. Oh well. > > Although, failing to boot *does* end up letting us know that new > machines exist. Otherwise people don't tell us, and will probably just > ship them. Yeah, but if we're doing it right we shouldn't have to care about every new machine type. QA is someone else's problem ;) > > -- > Stewart Smith > OPAL Architect, IBM. >
Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes: > We have new platform type under ZZ. Lets add them. With this fix > we are able to boot the system. > > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > --- > platforms/ibm-fsp/zz.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/platforms/ibm-fsp/zz.c b/platforms/ibm-fsp/zz.c > index 705906a04..96259c35b 100644 > --- a/platforms/ibm-fsp/zz.c > +++ b/platforms/ibm-fsp/zz.c > @@ -51,7 +51,10 @@ static bool zz_probe(void) > if (dt_node_is_compatible(dt_root, "ibm,zz-1s2u") || > dt_node_is_compatible(dt_root, "ibm,zz-1s4u") || > dt_node_is_compatible(dt_root, "ibm,zz-2s2u") || > - dt_node_is_compatible(dt_root, "ibm,zz-2s4u")) > + dt_node_is_compatible(dt_root, "ibm,zz-2s4u") || > + dt_node_is_compatible(dt_root, "ibm,zz-1s4u+gen4") || > + dt_node_is_compatible(dt_root, "ibm,zz-2s2u+gen4") || > + dt_node_is_compatible(dt_root, "ibm,zz-2s4u+gen4")) > return true; merged to master as of 0bf01d93ee39c48fa06b5d4ecbac77f5592395b6
diff --git a/platforms/ibm-fsp/zz.c b/platforms/ibm-fsp/zz.c index 705906a04..96259c35b 100644 --- a/platforms/ibm-fsp/zz.c +++ b/platforms/ibm-fsp/zz.c @@ -51,7 +51,10 @@ static bool zz_probe(void) if (dt_node_is_compatible(dt_root, "ibm,zz-1s2u") || dt_node_is_compatible(dt_root, "ibm,zz-1s4u") || dt_node_is_compatible(dt_root, "ibm,zz-2s2u") || - dt_node_is_compatible(dt_root, "ibm,zz-2s4u")) + dt_node_is_compatible(dt_root, "ibm,zz-2s4u") || + dt_node_is_compatible(dt_root, "ibm,zz-1s4u+gen4") || + dt_node_is_compatible(dt_root, "ibm,zz-2s2u+gen4") || + dt_node_is_compatible(dt_root, "ibm,zz-2s4u+gen4")) return true; return false;
We have new platform type under ZZ. Lets add them. With this fix we are able to boot the system. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> --- platforms/ibm-fsp/zz.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)