diff mbox series

opal-api: Document hole in the token list

Message ID 20190529043732.14044-1-oohall@gmail.com
State Accepted
Headers show
Series opal-api: Document hole in the token list | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success Successfully applied on branch master (76f7316bc8fc8a18fdbfcbc0e1fe1bb992d2a7d7)
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot fail Test snowpatch/job/snowpatch-skiboot on branch master
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco success Signed-off-by present

Commit Message

Oliver O'Halloran May 29, 2019, 4:37 a.m. UTC
OPAL call tokens 46, 47, and 48 have been unused since the dawn of time
as far as I can tell. Document the hole so the next person to assume
it's contigious doesn't get tripped up by it.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
---
 include/opal-api.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Stewart Smith June 3, 2019, 2:11 a.m. UTC | #1
"Oliver O'Halloran" <oohall@gmail.com> writes:
> OPAL call tokens 46, 47, and 48 have been unused since the dawn of time
> as far as I can tell. Document the hole so the next person to assume
> it's contigious doesn't get tripped up by it.
>
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
> ---
>  include/opal-api.h | 3 +++
>  1 file changed, 3 insertions(+)

Merged to master as of b557b79a3a3cd34b08b5919aa05e3a4b21616e29.
diff mbox series

Patch

diff --git a/include/opal-api.h b/include/opal-api.h
index b0ad435539fb..16a9a9a95b24 100644
--- a/include/opal-api.h
+++ b/include/opal-api.h
@@ -105,6 +105,9 @@ 
 #define OPAL_WRITE_OPPANEL			43 /* unimplemented */
 #define OPAL_PCI_MAP_PE_DMA_WINDOW		44
 #define OPAL_PCI_MAP_PE_DMA_WINDOW_REAL		45
+/* 46 is unused */
+/* 47 is unused */
+/* 48 is unused */
 #define OPAL_PCI_RESET				49
 #define OPAL_PCI_GET_HUB_DIAG_DATA		50
 #define OPAL_PCI_GET_PHB_DIAG_DATA		51