| Message ID | 20190225052436.20770-1-stewart@linux.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/6] sparse: symbol 'sbe_timer_lock' was not declared. Should it be static? | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | master/apply_patch Successfully applied |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | success | Test snowpatch/job/snowpatch-skiboot on branch master |
On 02/25/2019 10:54 AM, Stewart Smith wrote: > Yes, yes it should. > > Signed-off-by: Stewart Smith <stewart@linux.ibm.com> I don't recall why I missed to make it as static. Thanks for the fix. Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> -Vasant
Stewart Smith <stewart@linux.ibm.com> writes:
> Yes, yes it should.
Series merged to master as of 3b8b7e8c4e7880f992092856ae25d4bd3d53126b.
diff --git a/hw/sbe-p9.c b/hw/sbe-p9.c index d52ada15a39f..c28dbb9d6f08 100644 --- a/hw/sbe-p9.c +++ b/hw/sbe-p9.c @@ -1,4 +1,4 @@ -/* Copyright 2017-2018 IBM Corp. +/* Copyright 2017-2019 IBM Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -91,7 +91,7 @@ static uint64_t sbe_last_gen_stamp; static uint64_t sbe_timer_target; /* Timer lock */ -struct lock sbe_timer_lock; +static struct lock sbe_timer_lock; /* * Minimum timeout value for P9 is 500 microseconds. After that
Yes, yes it should. Signed-off-by: Stewart Smith <stewart@linux.ibm.com> --- hw/sbe-p9.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)