From patchwork Thu Feb 21 06:28:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jeffery X-Patchwork-Id: 1045786 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 444l5T3190z9s8m for ; Thu, 21 Feb 2019 17:32:45 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=aj.id.au header.i=@aj.id.au header.b="jfw3vXFj"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="IVZ7K43X"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 444l5T2158zDqNn for ; Thu, 21 Feb 2019 17:32:45 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=aj.id.au (client-ip=66.111.4.26; helo=out2-smtp.messagingengine.com; envelope-from=andrew@aj.id.au; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=aj.id.au header.i=@aj.id.au header.b="jfw3vXFj"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="IVZ7K43X"; dkim-atps=neutral Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 444l1p5QtRzDqNQ for ; Thu, 21 Feb 2019 17:29:34 +1100 (AEDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3F4CB2218B; Thu, 21 Feb 2019 01:29:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 21 Feb 2019 01:29:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=JH/NDgHoQYhro lyZz9pQwD+Vgz7iCaEqmIN4USPEuEw=; b=jfw3vXFjWg6/+mtIkVyJRoiGkwacf Q9HybM0+6OkQ5k7gXFmHnFTsr+EAmBJ5FFr6QZVI9n+oT+IdvIt2c8N6um3DmNU7 lHShMeDa89x97DpH2ovLQhRoU3dxhaEDf4sk6QtX+2EF7If+bip0IYG+K2uM4HZU nAa/T8irlN9AHT1VQ3zFkwZA6p3lbUD8fOzg97NITmhqmZbPWEBxOneBXY3EYf+w aolBlCq4wIUuw8/PZlFLFJ9m2OEjJSeQ1Z6YOJEH0NOkWGPa3evS1xDL+vVZA7dM bO+LcFnKnClGrMwaTKuOKXf7QszESkyEPHSpZWppLnC2VZRIbwvMiZyYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=JH/NDgHoQYhrolyZz9pQwD+Vgz7iCaEqmIN4USPEuEw=; b=IVZ7K43X BhUoffD3WMKeD0tmg4wEQXSSqbdTeWIcmD4SYdi9EsxPJM1OmCILM8uD5MJj9lko 5H2B1+U/J45gk5R9/iB2LoLAknQ9muxTAUsIF5zUERfdiIAgmVvvgMkLmal1VurD DRlKCfLnQ5xiCjOuHkv3MNfRPu+TmomsysWUROdMQQOiXPMxbhLmyFOSRszg5o/M MHwuWa1PHiQn0pG4isOKM1NRQrnJyt+86yPhNGxh9cvWm3jpvlrQ/z3htlfC1xuh VD7+JESdP3G7qOkpD7VeoBZAh9z6itVplSO7AJiD9/nrRizVTQ0gn8ozK8KjnBud XcBA+KEMdvhSlQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrtdejgdeljeculddtuddrgedtledrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre dtredttdenucfhrhhomheptehnughrvgifucflvghffhgvrhihuceorghnughrvgifsegr jhdrihgurdgruheqnecukfhppedvtddvrdekuddrudekrddvkeenucfrrghrrghmpehmrg hilhhfrhhomheprghnughrvgifsegrjhdrihgurdgruhenucevlhhushhtvghrufhiiigv peeg X-ME-Proxy: Received: from mistburn.bha-au.ibmmobiledemo.com (unknown [202.81.18.28]) by mail.messagingengine.com (Postfix) with ESMTPA id 6B489E4210; Thu, 21 Feb 2019 01:29:30 -0500 (EST) From: Andrew Jeffery To: skiboot@lists.ozlabs.org Date: Thu, 21 Feb 2019 16:58:08 +1030 Message-Id: <20190221062851.21958-10-andrew@aj.id.au> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190221062851.21958-1-andrew@aj.id.au> References: <20190221062851.21958-1-andrew@aj.id.au> MIME-Version: 1.0 Subject: [Skiboot] [PATCH v2 09/52] test-ipmi-hiomap: Print some information on early scenario_exit() X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Now we dump the index of the event that we exited on if it's not the appropriate scenario event type. Cc: stable Signed-off-by: Andrew Jeffery --- libflash/test/test-ipmi-hiomap.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libflash/test/test-ipmi-hiomap.c b/libflash/test/test-ipmi-hiomap.c index 738352cc89f1..4e1232f22ed0 100644 --- a/libflash/test/test-ipmi-hiomap.c +++ b/libflash/test/test-ipmi-hiomap.c @@ -96,7 +96,12 @@ static void scenario_advance(void) static void scenario_exit(void) { - assert(ipmi_msg_ctx.cursor->type == scenario_sentinel); + if (ipmi_msg_ctx.cursor->type != scenario_sentinel) { + ptrdiff_t d = ipmi_msg_ctx.cursor - ipmi_msg_ctx.scenario; + printf("%s: Exiting on event %tu with event type %d \n", + __func__, d, ipmi_msg_ctx.cursor->type); + assert(false); + } } void ipmi_init_msg(struct ipmi_msg *msg, int interface __attribute__((unused)),