Message ID | 20190215065708.6086-7-andrew@aj.id.au |
---|---|
State | Changes Requested |
Headers | show
Return-Path: <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4413zw0Frfz9s4Z for <incoming@patchwork.ozlabs.org>; Fri, 15 Feb 2019 18:00:12 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=aj.id.au header.i=@aj.id.au header.b="HhpOIlaM"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="YfxcIWiU"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4413zv5zxSzDqVM for <incoming@patchwork.ozlabs.org>; Fri, 15 Feb 2019 18:00:11 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=aj.id.au (client-ip=66.111.4.26; helo=out2-smtp.messagingengine.com; envelope-from=andrew@aj.id.au; receiver=<UNKNOWN>) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=aj.id.au header.i=@aj.id.au header.b="HhpOIlaM"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="YfxcIWiU"; dkim-atps=neutral Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4413x41XRHzDqVx for <skiboot@lists.ozlabs.org>; Fri, 15 Feb 2019 17:57:44 +1100 (AEDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 03C672225D; Fri, 15 Feb 2019 01:57:42 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 15 Feb 2019 01:57:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=BMdYlBSVz4/8E XHSjM1lfN1NzFED6lSCCdB8F7RUbSM=; b=HhpOIlaMB3soqht/RpNIhf8S8ibzh jVMqMNBJ6bqy09BqtyOWoqQBojHtdYcAnKs0GIMH6nNfsPborLc6i665ho9i+v+K VXiSzP+ZjDn9aWn5LyATXENu2Kk0UuuLLKtHuek1DurR6/G6KonJY/eq/xlmoAfV 5g/VvomvZaKNgiUADANKt+dFadkcjb4awfzM3w17tY9Dx44IDv+SmyOzcIa9siqF u0kyu6lRIwPOj91xMbR69SIwvjTTTWRIjrF2PltL5Q5pwJashPJs0cjiNRlNAR29 iTDetvLUZkqfc2yIzgyfCRfcGS0HKIJugMkSf8VvhvBZU0VRRO4i07feA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=BMdYlBSVz4/8EXHSjM1lfN1NzFED6lSCCdB8F7RUbSM=; b=YfxcIWiU /CjzipFrEUr+/3SZ1oJefyT0HfDf/6rpeFZZc76VSA7Sbtzm5ZTdET4ESswy9anu n6u889RxNGxZmUT7Yf69cVV6rSfLFBbMFvax0w2DLp4wjZFcN/eOBJEryYp3ZujS rcbp2N6Bq04UPsYvgf+cTPRAUmm1Qd4bQBKmkQ71Y0XIWW5IaRHvtwQ8vjS7cCaX Wm8t68F9U3zxzE7xeNDXoO/LiCmfRBGW1Hkx2pxAOPaMwIyqwQjardryvXg/dBEp 8Wd9PEZlAxfYGxi21yVZpy4yvdR9p4qUFnnwXaNzMU2JrEB4HDRabS6cisTMeNJP AyMwQq0p1cJtDw== X-ME-Sender: <xms:5WJmXGRm_pq0GkDLQ9UOXY9JWasMDG4kZ3dmqgvjRXm5fA7GzbMwUg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtiedgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecunecujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpe etnhgurhgvficulfgvfhhfvghrhicuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucfk phepudegrddvrdekledrjeehnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvfi esrghjrdhiugdrrghunecuvehluhhsthgvrhfuihiivgepvd X-ME-Proxy: <xmx:5WJmXABmpEtzk_SIdBFbf50M3LwEVSHyR90oLXt8nJ0jBovYN3U8Ow> <xmx:5WJmXO1aTrJui7yQL-LIIUguSeTQrlGt983UP4pxJs-bSeVWtHXGPg> <xmx:5WJmXGWuiLg_zsi_U6wOsYOtGaRvv9DVzfFPyHbe8YfNL-fCTtEHow> <xmx:5WJmXK1m7xKmIpHm0_eyAEcoQ1sVPlAUQ4DPIi_7hYD7MXYQu1rmeQ> Received: from localhost.localdomain (unknown [14.2.89.75]) by mail.messagingengine.com (Postfix) with ESMTPA id B12CFE409D; Fri, 15 Feb 2019 01:57:39 -0500 (EST) From: Andrew Jeffery <andrew@aj.id.au> To: skiboot@lists.ozlabs.org Date: Fri, 15 Feb 2019 17:26:23 +1030 Message-Id: <20190215065708.6086-7-andrew@aj.id.au> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190215065708.6086-1-andrew@aj.id.au> References: <20190215065708.6086-1-andrew@aj.id.au> MIME-Version: 1.0 Subject: [Skiboot] [PATCH 06/51] test-ipmi-hiomap: Dump unexpected IPMI messages X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development <skiboot.lists.ozlabs.org> List-Unsubscribe: <https://lists.ozlabs.org/options/skiboot>, <mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe> List-Archive: <http://lists.ozlabs.org/pipermail/skiboot/> List-Post: <mailto:skiboot@lists.ozlabs.org> List-Help: <mailto:skiboot-request@lists.ozlabs.org?subject=help> List-Subscribe: <https://lists.ozlabs.org/listinfo/skiboot>, <mailto:skiboot-request@lists.ozlabs.org?subject=subscribe> Cc: Andrew Jeffery <andrew@aj.id.au> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> |
Series |
ipmi-hiomap: Tests and fixes for event handling
|
expand
|
diff --git a/libflash/test/test-ipmi-hiomap.c b/libflash/test/test-ipmi-hiomap.c index 19e0cbf5c846..e2330fe85486 100644 --- a/libflash/test/test-ipmi-hiomap.c +++ b/libflash/test/test-ipmi-hiomap.c @@ -146,6 +146,9 @@ void ipmi_queue_msg_sync(struct ipmi_msg *msg) assert(ctx->cursor->p->type == scenario_cmd); cmd = &ctx->cursor->p->c; } else { + printf("Got unexpected request:\n"); + for (ssize_t i = 0; i < msg->req_size; i++) + printf("msg->data[%zd]: 0x%02x\n", i, msg->data[i]); assert(false); }
These indicate an implementation bug or broken scenario. Either way it's helpful to know what arrived given it wasn't expected. Signed-off-by: Andrew Jeffery <andrew@aj.id.au> --- libflash/test/test-ipmi-hiomap.c | 3 +++ 1 file changed, 3 insertions(+)