| Message ID | 20181121061601.18109-1-sam@mendozajonas.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] libflash: Restore blocklevel tests | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | master/apply_patch Successfully applied |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | success | Test snowpatch/job/snowpatch-skiboot on branch master |
On Wed, 21 Nov 2018, at 16:46, Samuel Mendoza-Jonas wrote: > This fell out in f58be46 "libflash/test: Rewrite Makefile.check to > improve scalability". Add it back in as test-blocklevel. Ah whoops. Thanks for fixing that. Acked-by: Andrew Jeffery <andrew@aj.id.au> > > Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com> > --- > libflash/test/Makefile.check | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/libflash/test/Makefile.check b/libflash/test/Makefile.check > index e0d55fa0..f5ed1ee7 100644 > --- a/libflash/test/Makefile.check > +++ b/libflash/test/Makefile.check > @@ -4,6 +4,10 @@ libflash_test_test_ipmi_hiomap_SOURCES = \ > libflash/test/stubs.c \ > libflash/ipmi-hiomap.c > > +libflash_test_test_blocklevel_SOURCES = \ > + libflash/test/test-blocklevel.c \ > + libflash/test/stubs.c > + > libflash_test_test_flash_SOURCES = \ > libflash/test/test-flash.c \ > libflash/test/stubs.c \ > @@ -21,6 +25,7 @@ libflash_test_test_mbox_SOURCES = \ > > check_PROGRAMS = \ > libflash/test/test-ipmi-hiomap \ > + libflash/test/test-blocklevel \ > libflash/test/test-flash \ > libflash/test/test-ecc \ > libflash/test/test-mbox > -- > 2.19.1 > > _______________________________________________ > Skiboot mailing list > Skiboot@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/skiboot
Samuel Mendoza-Jonas <sam@mendozajonas.com> writes: > This fell out in f58be46 "libflash/test: Rewrite Makefile.check to > improve scalability". Add it back in as test-blocklevel. > > Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com> Series merged to master as of e247710814227a7122915ff44474e0c8aa26fd3a. I'm guessing this should also go to stable?
On Mon, 2018-11-26 at 18:10 +1100, Stewart Smith wrote: > Samuel Mendoza-Jonas <sam@mendozajonas.com> writes: > > This fell out in f58be46 "libflash/test: Rewrite Makefile.check to > > improve scalability". Add it back in as test-blocklevel. > > > > Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com> > > Series merged to master as of e247710814227a7122915ff44474e0c8aa26fd3a. > > I'm guessing this should also go to stable? > Yeah, I don't think we hit it on any stable builds but that's probably luck from the PNOR layout not being updated. Want me to resend for stable?
Samuel Mendoza-Jonas <sam@mendozajonas.com> writes: > On Mon, 2018-11-26 at 18:10 +1100, Stewart Smith wrote: >> Samuel Mendoza-Jonas <sam@mendozajonas.com> writes: >> > This fell out in f58be46 "libflash/test: Rewrite Makefile.check to >> > improve scalability". Add it back in as test-blocklevel. >> > >> > Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com> >> >> Series merged to master as of e247710814227a7122915ff44474e0c8aa26fd3a. >> >> I'm guessing this should also go to stable? >> > > Yeah, I don't think we hit it on any stable builds but that's probably > luck from the PNOR layout not being updated. Want me to resend for > stable? I cherry-picked it over as of d0dce2b973d184af5ec9e87e0bc847336ca351ef and ran tests. Released 6.0.14 with it this morning.
diff --git a/libflash/test/Makefile.check b/libflash/test/Makefile.check index e0d55fa0..f5ed1ee7 100644 --- a/libflash/test/Makefile.check +++ b/libflash/test/Makefile.check @@ -4,6 +4,10 @@ libflash_test_test_ipmi_hiomap_SOURCES = \ libflash/test/stubs.c \ libflash/ipmi-hiomap.c +libflash_test_test_blocklevel_SOURCES = \ + libflash/test/test-blocklevel.c \ + libflash/test/stubs.c + libflash_test_test_flash_SOURCES = \ libflash/test/test-flash.c \ libflash/test/stubs.c \ @@ -21,6 +25,7 @@ libflash_test_test_mbox_SOURCES = \ check_PROGRAMS = \ libflash/test/test-ipmi-hiomap \ + libflash/test/test-blocklevel \ libflash/test/test-flash \ libflash/test/test-ecc \ libflash/test/test-mbox
This fell out in f58be46 "libflash/test: Rewrite Makefile.check to improve scalability". Add it back in as test-blocklevel. Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com> --- libflash/test/Makefile.check | 5 +++++ 1 file changed, 5 insertions(+)