| Message ID | 20180919083120.5668-1-hegdevasant@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] FSP: Improve Reset/Reload log message | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | master/apply_patch Successfully applied |
| snowpatch_ozlabs/make_check | success | Test make_check on branch master |
On Wed, Sep 19, 2018 at 02:01:20PM +0530, Vasant Hegde wrote: > Below message is confusing. Lets make it clear. > > FSP sends "R/R complete notification" whenever there is a dump. We use `flag` > to identify whether its its R/R completion -OR- just new dump notification. > > [ 483.406351956,6] FSP: SP says Reset/Reload complete > [ 483.406354278,5] DUMP: FipS dump available. ID = 0x1a00001f [size: 6367640 bytes] > [ 483.406355968,7] A Reset/Reload was NOT done > > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Acked-by: Ananth N Mavinakayanahalli <ananth@linux.ibm.com>
Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes: > Below message is confusing. Lets make it clear. > > FSP sends "R/R complete notification" whenever there is a dump. We use `flag` > to identify whether its its R/R completion -OR- just new dump notification. > > [ 483.406351956,6] FSP: SP says Reset/Reload complete > [ 483.406354278,5] DUMP: FipS dump available. ID = 0x1a00001f [size: 6367640 bytes] > [ 483.406355968,7] A Reset/Reload was NOT done > > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> thanks! Merged to master as of c4cd17e3d878b944e50350842082ccd70caad046
diff --git a/hw/fsp/fsp.c b/hw/fsp/fsp.c index 4beb33053..f7e674830 100644 --- a/hw/fsp/fsp.c +++ b/hw/fsp/fsp.c @@ -1299,7 +1299,6 @@ static bool fsp_local_command(u32 cmd_sub_mod, struct fsp_msg *msg) fsp_alloc_inbound(msg); return true; case FSP_CMD_SP_RELOAD_COMP: - prlog(PR_INFO, "FSP: SP says Reset/Reload complete\n"); if (msg->data.bytes[3] & PPC_BIT8(0)) { fsp_fips_dump_notify(msg->data.words[1], msg->data.words[2]); @@ -1309,8 +1308,9 @@ static bool fsp_local_command(u32 cmd_sub_mod, struct fsp_msg *msg) msg->data.words[3]); } if (msg->data.bytes[3] & PPC_BIT8(2)) { - prlog(PR_DEBUG, " A Reset/Reload was NOT done\n"); + prlog(PR_INFO, "FSP: SP Reset/Reload was NOT done\n"); } else { + prlog(PR_INFO, "FSP: SP says Reset/Reload complete\n"); /* Notify clients that the FSP is back up */ fsp_notify_rr_state(FSP_RELOAD_COMPLETE); fsp_repost_queued_msgs_post_rr();
Below message is confusing. Lets make it clear. FSP sends "R/R complete notification" whenever there is a dump. We use `flag` to identify whether its its R/R completion -OR- just new dump notification. [ 483.406351956,6] FSP: SP says Reset/Reload complete [ 483.406354278,5] DUMP: FipS dump available. ID = 0x1a00001f [size: 6367640 bytes] [ 483.406355968,7] A Reset/Reload was NOT done Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> --- Changes in v2: - Replaced PR_DEBUG with PR_INFO. -Vasant hw/fsp/fsp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)