diff mbox series

phb4: Use the return value of phb4_fenced() in phb4_get_diag_data()

Message ID 20180814111443.27861-1-vaibhav@linux.ibm.com
State Not Applicable
Headers show
Series phb4: Use the return value of phb4_fenced() in phb4_get_diag_data() | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success master/apply_patch Successfully applied
snowpatch_ozlabs/make_check success Test make_check on branch master

Commit Message

Vaibhav Jain Aug. 14, 2018, 11:14 a.m. UTC 
From: Cyril Bur <cyril.bur@au1.ibm.com>

phb4_get_diag_data() checks the flags for the PHB4_AIB_FENCED after
having called phb4_fenced(). This information is returned by
phb4_fenced().

This patch was prompted by an unused return value warning in Coverity.

Fixes: CID 163734
Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
---
 hw/phb4.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Vaibhav Jain Aug. 14, 2018, 11:18 a.m. UTC | #1 
Please ignore this patch email.

Vaibhav Jain <vaibhav@linux.ibm.com> writes:

> From: Cyril Bur <cyril.bur@au1.ibm.com>
>
> phb4_get_diag_data() checks the flags for the PHB4_AIB_FENCED after
> having called phb4_fenced(). This information is returned by
> phb4_fenced().
>
> This patch was prompted by an unused return value warning in Coverity.
>
> Fixes: CID 163734
> Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com>
> Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
> ---
>  hw/phb4.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/phb4.c b/hw/phb4.c
> index 4b1acd9e..5e07e2bc 100644
> --- a/hw/phb4.c
> +++ b/hw/phb4.c
> @@ -3755,6 +3755,7 @@ static int64_t phb4_get_diag_data(struct phb *phb,
>  				  void *diag_buffer,
>  				  uint64_t diag_buffer_len)
>  {
> +	bool fenced;
>  	struct phb4 *p = phb_to_phb4(phb);
>  	struct OpalIoPhb4ErrorData *data = diag_buffer;
>  
> @@ -3767,10 +3768,10 @@ static int64_t phb4_get_diag_data(struct phb *phb,
>  	 * Dummy check for fence so that phb4_read_phb_status knows
>  	 * whether to use ASB or AIB
>  	 */
> -	phb4_fenced(p);
> +	fenced = phb4_fenced(p);
>  	phb4_read_phb_status(p, data);
>  
> -	if (!(p->flags & PHB4_AIB_FENCED))
> +	if (!fenced)
>  		phb4_eeh_dump_regs(p);
>  
>  	/*
> -- 
> 2.17.1
>
diff mbox series

Patch

diff --git a/hw/phb4.c b/hw/phb4.c
index 4b1acd9e..5e07e2bc 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -3755,6 +3755,7 @@  static int64_t phb4_get_diag_data(struct phb *phb,
 				  void *diag_buffer,
 				  uint64_t diag_buffer_len)
 {
+	bool fenced;
 	struct phb4 *p = phb_to_phb4(phb);
 	struct OpalIoPhb4ErrorData *data = diag_buffer;
 
@@ -3767,10 +3768,10 @@  static int64_t phb4_get_diag_data(struct phb *phb,
 	 * Dummy check for fence so that phb4_read_phb_status knows
 	 * whether to use ASB or AIB
 	 */
-	phb4_fenced(p);
+	fenced = phb4_fenced(p);
 	phb4_read_phb_status(p, data);
 
-	if (!(p->flags & PHB4_AIB_FENCED))
+	if (!fenced)
 		phb4_eeh_dump_regs(p);
 
 	/*