| Message ID | 20180503085837.12358-1-stewart@linux.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | core/hmi: assign flags=0 in case nothing set by handle_hmi_exception | expand |
On 05/03/2018 02:28 PM, Stewart Smith wrote: > Practically speaking, I don't think you'd *currently* hit this. > > Found with Clang's scan-build. > > Signed-off-by: Stewart Smith <stewart@linux.ibm.com> It is indeed a bug fix. Acked-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com> > --- > core/hmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/core/hmi.c b/core/hmi.c > index bd0fc13b80d8..9dbc473706ad 100644 > --- a/core/hmi.c > +++ b/core/hmi.c > @@ -1296,7 +1296,7 @@ opal_call(OPAL_HANDLE_HMI, opal_handle_hmi, 0); > > static int64_t opal_handle_hmi2(__be64 *out_flags) > { > - uint64_t hmer, flags; > + uint64_t hmer, flags = 0; > struct OpalHMIEvent hmi_evt; > > /* >
Stewart Smith <stewart@linux.ibm.com> writes: > Practically speaking, I don't think you'd *currently* hit this. > > Found with Clang's scan-build. > > Signed-off-by: Stewart Smith <stewart@linux.ibm.com> Merged to master as of aa59e48064b46da4b1a508c4daca4ea8c50d464a
diff --git a/core/hmi.c b/core/hmi.c index bd0fc13b80d8..9dbc473706ad 100644 --- a/core/hmi.c +++ b/core/hmi.c @@ -1296,7 +1296,7 @@ opal_call(OPAL_HANDLE_HMI, opal_handle_hmi, 0); static int64_t opal_handle_hmi2(__be64 *out_flags) { - uint64_t hmer, flags; + uint64_t hmer, flags = 0; struct OpalHMIEvent hmi_evt; /*
Practically speaking, I don't think you'd *currently* hit this. Found with Clang's scan-build. Signed-off-by: Stewart Smith <stewart@linux.ibm.com> --- core/hmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)