diff mbox series

npu2: Remove unused fields in struct npu2

Message ID 20180316034608.10048-1-andrew.donnellan@au1.ibm.com
State Accepted
Headers show
Series npu2: Remove unused fields in struct npu2 | expand

Commit Message

Andrew Donnellan March 16, 2018, 3:46 a.m. UTC 
Trivial cleanup of two unused fields in struct npu2.

Cc: Alistair Popple <alistair@popple.id.au>
Cc: Reza Arbab <arbab@linux.vnet.ibm.com>
Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
---
 include/npu2.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Alistair Popple March 16, 2018, 5:05 a.m. UTC | #1 
Thanks! Looks like these were probably just a cut & paste job from NVLink1 code.

Acked-By: Alistair Popple <alistair@popple.id.au>

On Friday, 16 March 2018 2:46:08 PM AEDT Andrew Donnellan wrote:
> Trivial cleanup of two unused fields in struct npu2.
> 
> Cc: Alistair Popple <alistair@popple.id.au>
> Cc: Reza Arbab <arbab@linux.vnet.ibm.com>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> ---
>  include/npu2.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/npu2.h b/include/npu2.h
> index eee57a7bd761..b95e1d3a4056 100644
> --- a/include/npu2.h
> +++ b/include/npu2.h
> @@ -140,10 +140,8 @@ struct npu2_dev {
>  struct npu2 {
>  	uint32_t	index;
>  	struct dt_node	*dt_node;
> -	uint32_t	flags;
>  	uint32_t	chip_id;
>  	uint64_t	xscom_base;
> -	uint64_t	at_xscom;
>  	void		*regs;
>  	uint64_t	mm_base;
>  	uint64_t	mm_size;
>
Reza Arbab March 16, 2018, 2:59 p.m. UTC | #2 
On Fri, Mar 16, 2018 at 02:46:08PM +1100, Andrew Donnellan wrote:
>Trivial cleanup of two unused fields in struct npu2.

Acked-by: Reza Arbab <arbab@linux.vnet.ibm.com>
Stewart Smith March 23, 2018, 5:55 a.m. UTC | #3 
Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes:
> Trivial cleanup of two unused fields in struct npu2.
>
> Cc: Alistair Popple <alistair@popple.id.au>
> Cc: Reza Arbab <arbab@linux.vnet.ibm.com>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> ---
>  include/npu2.h | 2 --
>  1 file changed, 2 deletions(-)

sweet. Merged to master as of d8c596368279a489f17d3412acdcca4aa6452803
diff mbox series

Patch

diff --git a/include/npu2.h b/include/npu2.h
index eee57a7bd761..b95e1d3a4056 100644
--- a/include/npu2.h
+++ b/include/npu2.h
@@ -140,10 +140,8 @@  struct npu2_dev {
 struct npu2 {
 	uint32_t	index;
 	struct dt_node	*dt_node;
-	uint32_t	flags;
 	uint32_t	chip_id;
 	uint64_t	xscom_base;
-	uint64_t	at_xscom;
 	void		*regs;
 	uint64_t	mm_base;
 	uint64_t	mm_size;