diff mbox series

hdata: Rename 'fsp-ipl-side' as 'sp-ipl-side'

Message ID 20171013112959.1276-1-hegdevasant@linux.vnet.ibm.com
State Accepted
Headers show
Series hdata: Rename 'fsp-ipl-side' as 'sp-ipl-side' | expand

Commit Message

Vasant Hegde Oct. 13, 2017, 11:29 a.m. UTC 
.. as OPAL is building device tree for both FSP and BMC system.
Also I don't see anyone using this property today. Hence renaming
should be fine.

Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
---
 hdata/spira.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

Comments

Stewart Smith Nov. 10, 2017, 4:33 a.m. UTC | #1 
Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes:

> .. as OPAL is building device tree for both FSP and BMC system.
> Also I don't see anyone using this property today. Hence renaming
> should be fine.
>
> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

Yeah, I think you're right in that it's safe to do (probably even on P8,
but being conservative here is good).

Merged to master as of eb858339cae8240367c82e6c2cc139519dbddb26
diff mbox series

Patch

diff --git a/hdata/spira.c b/hdata/spira.c
index a13f38e..bee549f 100644
--- a/hdata/spira.c
+++ b/hdata/spira.c
@@ -1046,9 +1046,15 @@  static void add_iplparams_ipl_params(const void *iplp, struct dt_node *node)
 	dt_add_property_strings(node, "cec-ipl-side",
 				(p->ipl_side & IPLPARAMS_CEC_FW_IPL_SIDE_TEMP) ?
 				"temp" : "perm");
-	dt_add_property_strings(node, "fsp-ipl-side",
-				(p->ipl_side & IPLPARAMS_FSP_FW_IPL_SIDE_TEMP) ?
-				"temp" : "perm");
+	if (proc_gen >= proc_gen_p9) {
+		dt_add_property_strings(node, "sp-ipl-side",
+					(p->ipl_side & IPLPARAMS_FSP_FW_IPL_SIDE_TEMP) ?
+					"temp" : "perm");
+	} else {
+		dt_add_property_strings(node, "fsp-ipl-side",
+					(p->ipl_side & IPLPARAMS_FSP_FW_IPL_SIDE_TEMP) ?
+					"temp" : "perm");
+	}
 	dt_add_property_cells(node, "os-ipl-mode", p->os_ipl_mode);
 	dt_add_property_strings(node, "cec-major-type",
 				p->cec_ipl_maj_type ? "hot" : "cold");